Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cudf::thread_index_type in merge.cu #13972

Merged
merged 5 commits into from
Sep 6, 2023
Merged

Use cudf::thread_index_type in merge.cu #13972

merged 5 commits into from
Sep 6, 2023

Conversation

divyegala
Copy link
Member

@divyegala divyegala commented Aug 26, 2023 •
edited
Loading

Description

This PR uses cudf::thread_index_type to avoid overflows.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@divyegala divyegala added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 26, 2023
@divyegala divyegala self-assigned this Aug 26, 2023
@divyegala divyegala requested a review from a team as a code owner August 26, 2023 00:26
@divyegala divyegala requested review from vyasr and bdice August 26, 2023 00:26
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 26, 2023
@GregoryKimball GregoryKimball mentioned this pull request Aug 28, 2023
Open
vyasr
vyasr requested changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One requested change, one suggestion re: stride.

cpp/src/merge/merge.cu Outdated Show resolved Hide resolved
cpp/src/merge/merge.cu Outdated Show resolved Hide resolved
ttnghia
ttnghia reviewed Sep 5, 2023
View reviewed changes
cpp/src/merge/merge.cu Outdated Show resolved Hide resolved
@vyasr vyasr self-requested a review September 6, 2023 16:12
@divyegala
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 1d7a77b into rapidsai:branch-23.10 Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia left review comments

@bdice bdice bdice approved these changes

@vyasr vyasr vyasr approved these changes

Assignees

@divyegala divyegala

Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@divyegala @vyasr @bdice @ttnghia