Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly depend on zlib in conda recipes #14018

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Explicitly depend on zlib in conda recipes #14018

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a09dda6
Explicitly depend on zlib in conda recipes
wence- Aug 31, 2023
509d9ea
Also depend on zlib in conda meta.yaml
wence- Aug 31, 2023
2582540
Respond to review
wence- Aug 31, 2023
9a535b6
Lower bound zlib to 1.2.13
wence- Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions conda/environments/all_cuda-118_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ dependencies:
- tokenizers==0.13.1
- transformers==4.24.0
- typing_extensions>=4.0.0
- zlib
- pip:
- git+https://github.com/python-streamz/streamz.git@master
name: all_cuda-118_arch-x86_64
1 change: 1 addition & 0 deletions conda/environments/all_cuda-120_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ dependencies:
- tokenizers==0.13.1
- transformers==4.24.0
- typing_extensions>=4.0.0
- zlib
- pip:
- git+https://github.com/python-streamz/streamz.git@master
name: all_cuda-120_arch-x86_64
2 changes: 2 additions & 0 deletions conda/recipes/libcudf/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ requirements:
- cuda-version ={{ cuda_version }}
- ninja
- sysroot_{{ target_platform }} {{ sysroot_version }}
- zlib
wence- marked this conversation as resolved.
Show resolved Hide resolved
host:
- librmm ={{ minor_version }}
- libkvikio ={{ minor_version }}
Expand Down Expand Up @@ -90,6 +91,7 @@ outputs:
requirements:
build:
- cmake {{ cmake_version }}
- zlib
wence- marked this conversation as resolved.
Show resolved Hide resolved
run:
{% if cuda_major == "11" %}
- cudatoolkit
Expand Down
1 change: 1 addition & 0 deletions dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ dependencies:
- c-compiler
- cxx-compiler
- dlpack>=0.5,<0.6.0a0
- zlib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wence- Can you comment on where/how we use zlib? Does it need to be in the conda package dependencies (meta.yml for libcudf, or cudf, …) as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue documenting the problems you see in builds?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is now: #14021

Copy link
Contributor

@vyasr vyasr Aug 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We support zlib compression/decompression in ORC reading/writing, so we should be including it in our recipe.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I was missing: #14021 (comment)

specific:
- output_types: conda
matrices:
Expand Down