Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] libcudf CI builds failing due to lack of zlib package #14021

Closed
wence- opened this issue Aug 31, 2023 · 1 comment · Fixed by #14018
Closed

[BUG] libcudf CI builds failing due to lack of zlib package #14021

wence- opened this issue Aug 31, 2023 · 1 comment · Fixed by #14018
Labels
bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code.

Comments

@wence-
Copy link
Contributor

wence- commented Aug 31, 2023

Describe the bug

Recently, the conda feedstock for cmake updated its run exports to remove dependency on (amongst other things) the zlib conda package.

It seems like we were relying on this transitively being pulled in for our builds. See for example a recent failure: https://github.com/rapidsai/cudf/actions/runs/6033351272/job/16385609807#step:7:635

We should therefore probably make this dependency explicit in dependencies.yaml and the conda recipe meta.yaml for libcudf.
@wence- wence- added bug Something isn't working Needs Triage Need team to review and classify labels Aug 31, 2023
@wence- wence- mentioned this issue Aug 31, 2023
Merged
3 tasks
@wence- wence- added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Aug 31, 2023
@bdice
Copy link
Contributor

bdice commented Aug 31, 2023 •
edited
Loading

This is where we actually use zlib in libcudf. This is the context I was missing:

cudf/cpp/CMakeLists.txt

Line 170 in c73ff70

rapids_find_package(ZLIB REQUIRED)

cudf/cpp/src/io/text/bgzip_utils.cpp

Line 17 in c73ff70

#include <zlib.h>

rapids-bot bot pushed a commit that referenced this issue Aug 31, 2023
@wence-
Explicitly depend on zlib in conda recipes (#14018)
a2fd688 
We were previously obtaining zlib transitively through our cmake dependency, but since the 3.27.4 conda package, this dependency no longer exists. Therefore we must depend on zlib ourselves.

- Closes #14021

Authors:
  - Lawrence Mitchell (https://github.com/wence-)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #14018
@bdice bdice removed the Needs Triage Need team to review and classify label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explicitly depend on zlib in conda recipes wence-/cudf
2 participants
@wence- @bdice