Fix 10 minute cupy notebook for older cupy versions #10631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
charlesbluca
added
3 - Ready for Review
galipremsagar
approved these changes
Apr 11, 2022
ajschmidt8
added a commit
to ajschmidt8/cudf
that referenced
this pull request
Apr 26, 2022
This PR updates a `from_dlpack` call that was missed in rapidsai#10631.
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
This PR updates a `from_dlpack` call that was missed in #10631. Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #10737
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a CuPy version check to the 10 minute CuPy notebook, using this to decide which DLPack input method to use - this should allow us to support older CuPy versions that don't yet have
from_dlpackwhile also supporting newer versions which will eventually deprecatefromDlpack.Closes #10612