Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cupy function in notebook #10737

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

ajschmidt8
Copy link
Member

This PR updates a from_dlpack call that was missed in #10631.

This PR updates a `from_dlpack` call that was missed in rapidsai#10631.
@ajschmidt8 ajschmidt8 added bug Something isn't working non-breaking Non-breaking change labels Apr 26, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Apr 26, 2022
@ajschmidt8
Copy link
Member Author

@gpucibot merge

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #10737 (4ec5153) into branch-22.06 (d6e3068) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 4ec5153 differs from pull request most recent head 3609d57. Consider uploading reports for the commit 3609d57 to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06   #10737      +/-   ##
================================================
+ Coverage         86.36%   86.39%   +0.03%     
================================================
  Files               142      142              
  Lines             22302    22304       +2     
================================================
+ Hits              19261    19270       +9     
+ Misses             3041     3034       -7     
Impacted Files Coverage Δ
python/cudf/cudf/core/frame.py 93.41% <ø> (ø)
python/cudf/cudf/testing/dataset_generator.py 73.25% <ø> (ø)
python/cudf/cudf/core/series.py 95.16% <100.00%> (+<0.01%) ⬆️
python/cudf/cudf/core/column/string.py 89.21% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.68% <0.00%> (+0.23%) ⬆️
python/cudf/cudf/core/column/numerical.py 96.17% <0.00%> (+0.29%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 92.91% <0.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2cd6b0...3609d57. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 1fdca07 into rapidsai:branch-22.06 Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants