Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 10 Minutes to cuDF and CuPy throws AttributeError #10612

Closed
robocopnixon opened this issue Apr 6, 2022 · 3 comments · Fixed by #10631
Closed

[BUG] 10 Minutes to cuDF and CuPy throws AttributeError #10612

robocopnixon opened this issue Apr 6, 2022 · 3 comments · Fixed by #10631
Labels
bug Something isn't working

Comments

@robocopnixon
Copy link

Describe the bug
The 10 Minutes to cuDF and CuPy throws the following error:
AttributeError: module 'cupy' has no attribute 'from_dlpack'

Steps/Code to reproduce bug
Run the notebook.

Expected behavior
This error should not appear in the notebook.

Environment overview (please complete the following information)

  • Environment location: Docker
  • Method of cuDF install: Docker
    • If method of install is [Docker], provide docker pull & docker run commands used
      docker pull rapidsai/rapidsai-core:22.02-cuda11.2-runtime-centos7-py3.8
      docker run --gpus all --rm -it -p 8888:8888 -p 8787:8787 -p 8786:8786 -v ~/extra:/rapids/notebooks/extra rapidsai/rapidsai-core-nightly:22.04-cuda11.2-runtime-centos7-py3.8
@robocopnixon robocopnixon added Needs Triage Need team to review and classify bug Something isn't working labels Apr 6, 2022
@charlesbluca
Copy link
Member

Looks like I introduced this issue through #10594, as my containers were picking up the newest version of CuPy (10.3.0) that gave a FutureWarning at the use of fromDlpack - out of interest, what version did you end up picking up in your containers?

Perhaps we should continue using fromDlpack here until our constraint is bumped enough that the majority of users would be calling from_dlpack? cc @galipremsagar since you originally reviewed #10594 not sure if you have some thoughts on this

@galipremsagar
Copy link
Contributor

galipremsagar commented Apr 7, 2022

Yeah, we currently support cupy 9.5.0 aswell which doesn't have from_dlpack. We can change back to using from_dlpack in 22.06 based on version. But not a pressing issue to do a patch release for 22.04 since it is in docs.

>>> import cupy as cp
>>> cp.fromDlpack
<built-in function fromDlpack>
>>> cp.from_dlpack
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/nvme/0/pgali/envs/cudfdev/lib/python3.8/site-packages/cupy/__init__.py", line 874, in __getattr__
    raise AttributeError(
AttributeError: module 'cupy' has no attribute 'from_dlpack'
>>> cp.__version__
'9.5.0'

cc: @shwina @rapidsai/ops just FYI.

@shwina
Copy link
Contributor

shwina commented Apr 7, 2022

To address @robocopnixon's original issue, it looks like one would need to use fromDlpack() instead of from_dlpack() (depending on what version of cupy got pulled into the container).

This is unfortunate, but I would agree it's too small a change for a patch release right now.

@charlesbluca charlesbluca linked a pull request Apr 11, 2022 that will close this issue
@bdice bdice removed the Needs Triage Need team to review and classify label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants