Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Unpin dask & distributed #10182

Merged
merged 38 commits into from
Mar 14, 2022
Merged

Conversation

galipremsagar
Copy link
Contributor

This PR unpin's max dask & distributed versions.

@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #10182 (555f00a) into branch-22.04 (0be0b00) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 555f00a differs from pull request most recent head 75c5ba3. Consider uploading reports for the commit 75c5ba3 to get more accurate results

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04   #10182      +/-   ##
================================================
+ Coverage         86.13%   86.15%   +0.01%     
================================================
  Files               139      139              
  Lines             22438    22438              
================================================
+ Hits              19328    19332       +4     
+ Misses             3110     3106       -4     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/string.py 88.39% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.57% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 90.56% <0.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a066e7f...75c5ba3. Read the comment docs.

ci/benchmark/build.sh Outdated Show resolved Hide resolved
ci/gpu/build.sh Outdated Show resolved Hide resolved
Copy link
Member

@charlesbluca charlesbluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work here @galipremsagar, happy to see tests are finally passing 🎉 just one more suggestion then this should be good to merge:

ci/benchmark/build.sh Outdated Show resolved Hide resolved
ci/gpu/build.sh Outdated Show resolved Hide resolved
Co-authored-by: Charles Blackmon-Luca <[email protected]>
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Mar 14, 2022
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a6fe301 into rapidsai:branch-22.04 Mar 14, 2022
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Mar 17, 2022
This PR upgrades `dask` & `distributed` min versions to be inline with: rapidsai/cudf#10182

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #2115
rapids-bot bot pushed a commit to rapidsai/dask-cuda that referenced this pull request Mar 21, 2022
This PR upgrades minimum versions of `dask` & `distributed`. Upstream changes have been made: rapidsai/cudf#10182

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Peter Andreas Entschev (https://github.com/pentschev)

URL: #872
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants