Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Upgrade min dask & distributed versions #872

Merged
merged 2 commits into from
Mar 21, 2022

Conversation

galipremsagar
Copy link
Contributor

This PR upgrades minimum versions of dask & distributed. Upstream changes have been made: rapidsai/cudf#10182

@galipremsagar galipremsagar requested a review from a team as a code owner March 14, 2022 18:36
@galipremsagar galipremsagar self-assigned this Mar 14, 2022
@github-actions github-actions bot added the conda conda issue label Mar 14, 2022
@galipremsagar galipremsagar added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Mar 14, 2022
@pentschev
Copy link
Member

We will still need a new release of Distributed and #870 to be merged, those were breaking changes.

@galipremsagar
Copy link
Contributor Author

We will still need a new release of Distributed and #870 to be merged, those were breaking changes.

This means we will require to upgrade min version to 2022.03.1 as opposed to 2022.02.1?

@galipremsagar
Copy link
Contributor Author

rerun tests

@pentschev
Copy link
Member

This means we will require to upgrade min version to 2022.03.1 as opposed to 2022.02.1?

Sorry I missed responding here. Yes, we'll need dask/distributed#5904 merged first, but likely this will be in 2022.03.0.

@jakirkham
Copy link
Member

PR ( dask/distributed#5904 ) just got merged, which I think fixes the issue here. The plan is to release Dask today. So hopefully that should unblock us here

conda/recipes/dask-cuda/meta.yaml Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@pentschev
Copy link
Member

rerun tests

1 similar comment
@pentschev
Copy link
Member

rerun tests

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything's green again, thanks @galipremsagar !

@pentschev
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a9fc857 into branch-22.04 Mar 21, 2022
ajschmidt8 added a commit to ajschmidt8/integration that referenced this pull request Mar 22, 2022
This PR updates the minimum `dask`/`distributed` versions to align with rapidsai/dask-cuda#872.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants