Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Unpin dask & distributed #10182

Merged
merged 38 commits into from
Mar 14, 2022
Merged
Show file tree
Hide file tree
Changes from 37 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
50149d0
unpin dask
galipremsagar Feb 1, 2022
abf829c
use nightly packages
galipremsagar Feb 1, 2022
0efc560
modify comments
galipremsagar Feb 1, 2022
7a41764
Merge remote-tracking branch 'upstream/branch-22.04' into unpin
galipremsagar Feb 1, 2022
8b717f9
remove dask nightly channel
galipremsagar Feb 1, 2022
3ea2f52
Apply suggestions from code review
galipremsagar Feb 1, 2022
5c417c6
Apply suggestions from code review
galipremsagar Feb 2, 2022
363716e
Merge remote-tracking branch 'upstream/branch-22.04' into unpin
galipremsagar Feb 10, 2022
8dfe18a
copyright
galipremsagar Feb 10, 2022
9ac4afe
Merge branch 'unpin' of https://github.com/galipremsagar/cudf into unpin
galipremsagar Feb 10, 2022
32b8597
Merge branch 'rapidsai:branch-22.04' into unpin
galipremsagar Feb 11, 2022
ad8a8e9
Update ci/gpu/build.sh
galipremsagar Feb 14, 2022
8293d80
Update ci/gpu/build.sh
galipremsagar Feb 15, 2022
9d69c86
Update build.sh
galipremsagar Feb 23, 2022
8de573f
Update build.sh
galipremsagar Feb 23, 2022
3d3032a
testing
galipremsagar Feb 23, 2022
919a5b0
Apply suggestions from code review
galipremsagar Feb 23, 2022
d9ad859
Apply suggestions from code review
galipremsagar Feb 23, 2022
779d808
Update ci/gpu/build.sh
galipremsagar Feb 25, 2022
c87978b
Merge branch 'rapidsai:branch-22.04' into unpin
galipremsagar Feb 25, 2022
8bde2ff
Update build.sh
galipremsagar Mar 10, 2022
d8aa8a9
Update build.sh
galipremsagar Mar 11, 2022
50ca04a
Update build.sh
galipremsagar Mar 11, 2022
9b63371
Update build.sh
galipremsagar Mar 11, 2022
7d9673e
Update build.sh
galipremsagar Mar 11, 2022
3fdb8c9
Update ci/benchmark/build.sh
galipremsagar Mar 11, 2022
72263af
Merge branch 'rapidsai:branch-22.04' into unpin
galipremsagar Mar 11, 2022
b1282c9
Apply suggestions from code review
galipremsagar Mar 11, 2022
e8a2e30
Merge branch 'rapidsai:branch-22.04' into unpin
galipremsagar Mar 11, 2022
ca8a1d9
Merge remote-tracking branch 'upstream/branch-22.04' into unpin
galipremsagar Mar 11, 2022
04b94cf
Merge branch 'unpin' of https://github.com/galipremsagar/cudf into unpin
galipremsagar Mar 11, 2022
f05490c
test
galipremsagar Mar 11, 2022
e877b11
Merge branch 'rapidsai:branch-22.04' into unpin
galipremsagar Mar 11, 2022
72960bd
tmp
galipremsagar Mar 11, 2022
d60d2c9
Merge branch 'unpin' of https://github.com/galipremsagar/cudf into unpin
galipremsagar Mar 11, 2022
9b1aeb6
Merge branch 'rapidsai:branch-22.04' into unpin
galipremsagar Mar 14, 2022
7981462
Update build.sh
galipremsagar Mar 14, 2022
75c5ba3
Apply suggestions from code review
galipremsagar Mar 14, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions ci/benchmark/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ export GBENCH_BENCHMARKS_DIR="$WORKSPACE/cpp/build/gbenchmarks/"
# like `/tmp` is.
export LIBCUDF_KERNEL_CACHE_PATH="$HOME/.jitify-cache"

# Dask & Distributed git tag
export DASK_DISTRIBUTED_GIT_TAG='2022.01.0'
# Dask & Distributed option to install main(nightly) or `conda-forge` packages.
export INSTALL_DASK_MAIN=1

function remove_libcudf_kernel_cache_dir {
EXITCODE=$?
Expand Down Expand Up @@ -77,11 +77,16 @@ conda install "rmm=$MINOR_VERSION.*" "cudatoolkit=$CUDA_REL" \
# conda remove -f rapids-build-env rapids-notebook-env
# conda install "your-pkg=1.0.0"

# Install the master version of dask, distributed, and streamz
logger "pip install git+https://github.com/dask/distributed.git@$DASK_DISTRIBUTED_GIT_TAG --upgrade --no-deps"
pip install "git+https://github.com/dask/distributed.git@$DASK_DISTRIBUTED_GIT_TAG" --upgrade --no-deps
logger "pip install git+https://github.com/dask/dask.git@$DASK_DISTRIBUTED_GIT_TAG --upgrade --no-deps"
pip install "git+https://github.com/dask/dask.git@$DASK_DISTRIBUTED_GIT_TAG" --upgrade --no-deps
# Install the conda-forge or nightly version of dask and distributed
if [[ "${INSTALL_DASK_MAIN}" == 1 ]]; then
gpuci_logger "gpuci_mamba_retry update dask"
gpuci_mamba_retry update dask
else
gpuci_logger "gpuci_mamba_retry install conda-forge::dask>=2022.02.1 conda-forge::distributed>=2022.02.1 --force-reinstall"
gpuci_mamba_retry install conda-forge::dask>=2022.02.1 conda-forge::distributed>=2022.02.1 --force-reinstall
galipremsagar marked this conversation as resolved.
Show resolved Hide resolved
fi

# Install the master version of streamz
logger "pip install git+https://github.com/python-streamz/streamz.git@master --upgrade --no-deps"
pip install "git+https://github.com/python-streamz/streamz.git@master" --upgrade --no-deps

Expand Down
5 changes: 3 additions & 2 deletions ci/cpu/build.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
# Copyright (c) 2018-2021, NVIDIA CORPORATION.
# Copyright (c) 2018-2022, NVIDIA CORPORATION.
##############################################
# cuDF CPU conda build script for CI #
##############################################
Expand Down Expand Up @@ -46,9 +46,10 @@ gpuci_logger "Activate conda env"
. /opt/conda/etc/profile.d/conda.sh
conda activate rapids

# Remove rapidsai-nightly channel if we are building main branch
# Remove `rapidsai-nightly` & `dask/label/dev` channel if we are building main branch
if [ "$SOURCE_BRANCH" = "main" ]; then
conda config --system --remove channels rapidsai-nightly
conda config --system --remove channels dask/label/dev
fi

gpuci_logger "Check compiler versions"
Expand Down
20 changes: 14 additions & 6 deletions ci/gpu/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ export CONDA_ARTIFACT_PATH="$WORKSPACE/ci/artifacts/cudf/cpu/.conda-bld/"
export GIT_DESCRIBE_TAG=`git describe --tags`
export MINOR_VERSION=`echo $GIT_DESCRIBE_TAG | grep -o -E '([0-9]+\.[0-9]+)'`

# Dask & Distributed git tag
export DASK_DISTRIBUTED_GIT_TAG='2022.01.0'
# Dask & Distributed option to install main(nightly) or `conda-forge` packages.
export INSTALL_DASK_MAIN=1

# ucx-py version
export UCX_PY_VERSION='0.25.*'
Expand Down Expand Up @@ -108,11 +108,19 @@ conda config --show-sources
conda list --show-channel-urls

function install_dask {
# Install the main version of dask, distributed, and streamz
gpuci_logger "Install the main version of dask, distributed, and streamz"
# Install the conda-forge or nightly version of dask and distributed
gpuci_logger "Install the conda-forge or nightly version of dask and distributed"
set -x
pip install "git+https://github.com/dask/distributed.git@$DASK_DISTRIBUTED_GIT_TAG" --upgrade --no-deps
pip install "git+https://github.com/dask/dask.git@$DASK_DISTRIBUTED_GIT_TAG" --upgrade --no-deps
if [[ "${INSTALL_DASK_MAIN}" == 1 ]]; then
gpuci_logger "gpuci_mamba_retry update dask"
gpuci_mamba_retry update dask
conda list
else
gpuci_logger "gpuci_mamba_retry install conda-forge::dask>=2022.02.1 conda-forge::distributed>=2022.02.1 --force-reinstall"
gpuci_mamba_retry install conda-forge::dask>=2022.02.1 conda-forge::distributed>=2022.02.1 --force-reinstall
galipremsagar marked this conversation as resolved.
Show resolved Hide resolved
fi
# Install the main version of streamz
gpuci_logger "Install the main version of streamz"
# Need to uninstall streamz that is already in the env.
pip uninstall -y streamz
pip install "git+https://github.com/python-streamz/streamz.git@master" --upgrade --no-deps
Expand Down
7 changes: 3 additions & 4 deletions conda/environments/cudf_dev_cuda11.5.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ channels:
- rapidsai
- nvidia
- rapidsai-nightly
- dask/label/dev
- conda-forge
dependencies:
- clang=11.1.0
Expand Down Expand Up @@ -42,8 +43,8 @@ dependencies:
- pydocstyle=6.1.1
- typing_extensions
- pre-commit
- dask>=2021.11.1,<=2022.01.0
- distributed>=2021.11.1,<=2022.01.0
- dask>=2022.02.1
- distributed>=2022.02.1
- streamz
- arrow-cpp=6.0.1
- dlpack>=0.5,<0.6.0a0
Expand All @@ -63,8 +64,6 @@ dependencies:
- librdkafka=1.7.0
- python-confluent-kafka=1.7.0
- pip:
- git+https://github.com/dask/dask.git@main
- git+https://github.com/dask/distributed.git@main
- git+https://github.com/python-streamz/streamz.git@master
- pyorc
- ptxcompiler # [linux64]
4 changes: 2 additions & 2 deletions conda/recipes/custreamz/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ requirements:
- python
- streamz
- cudf {{ version }}
- dask>=2021.11.1,<=2022.01.0
- distributed>=2021.11.1,<=2022.01.0
- dask>=2022.02.1
- distributed>=2022.02.1
- python-confluent-kafka >=1.7.0,<1.8.0a0
- cudf_kafka {{ version }}

Expand Down
10 changes: 5 additions & 5 deletions conda/recipes/dask-cudf/meta.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2018-2019, NVIDIA CORPORATION.
# Copyright (c) 2018-2022, NVIDIA CORPORATION.

{% set version = environ.get('GIT_DESCRIBE_TAG', '0.0.0.dev').lstrip('v') + environ.get('VERSION_SUFFIX', '') %}
{% set minor_version = version.split('.')[0] + '.' + version.split('.')[1] %}
Expand Down Expand Up @@ -27,14 +27,14 @@ requirements:
host:
- python
- cudf {{ version }}
- dask>=2021.11.1,<=2022.01.0
- distributed>=2021.11.1,<=2022.01.0
- dask>=2022.02.1
- distributed>=2022.02.1
- cudatoolkit {{ cuda_version }}
run:
- python
- cudf {{ version }}
- dask>=2021.11.1,<=2022.01.0
- distributed>=2021.11.1,<=2022.01.0
- dask>=2022.02.1
- distributed>=2022.02.1
- {{ pin_compatible('cudatoolkit', max_pin='x', min_pin='x') }}

test: # [linux64]
Expand Down
4 changes: 2 additions & 2 deletions python/custreamz/dev_requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
flake8==3.8.3
black==19.10b0
isort==5.6.4
dask>=2021.11.1,<=2022.01.0
distributed>=2021.11.1,<=2022.01.0
dask>=2022.02.1
distributed>=2022.02.1
streamz
python-confluent-kafka
pytest
Expand Down
4 changes: 2 additions & 2 deletions python/dask_cudf/dev_requirements.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright (c) 2021, NVIDIA CORPORATION.

dask>=2021.11.1,<=2022.01.0
distributed>=2021.11.1,<=2022.01.0
dask>=2022.02.1
distributed>=2022.02.1
fsspec>=0.6.0
numba>=0.53.1
numpy
Expand Down
6 changes: 3 additions & 3 deletions python/dask_cudf/setup.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2019-2021, NVIDIA CORPORATION.
# Copyright (c) 2019-2022, NVIDIA CORPORATION.

import os
import re
Expand All @@ -10,8 +10,8 @@

install_requires = [
"cudf",
"dask>=2021.11.1,<=2022.01.0",
"distributed>=2021.11.1,<=2022.01.0",
"dask>=2022.02.1",
"distributed>=2022.02.1",
"fsspec>=0.6.0",
"numpy",
"pandas>=1.0,<1.4.0dev0",
Expand Down