Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Unpin max dask and distributed versions #4546

Merged
merged 1 commit into from
Feb 10, 2022
Merged

[REVIEW] Unpin max dask and distributed versions #4546

merged 1 commit into from
Feb 10, 2022

Conversation

galipremsagar
Copy link
Contributor

Changed to be in-line with: rapidsai/cudf#10182

@galipremsagar galipremsagar requested a review from a team as a code owner February 1, 2022 17:45
@github-actions github-actions bot added conda conda issue gpuCI gpuCI issue labels Feb 1, 2022
@ajschmidt8
Copy link
Member

CI got stuck.

rerun tests

@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed non-breaking Non-breaking change labels Feb 2, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@a70044c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4546   +/-   ##
===============================================
  Coverage                ?   85.71%           
===============================================
  Files                   ?      236           
  Lines                   ?    19365           
  Branches                ?        0           
===============================================
  Hits                    ?    16599           
  Misses                  ?     2766           
  Partials                ?        0
Flag Coverage Δ
dask 46.48% <0.00%> (?)
non-dask 78.63% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a70044c...d29dab2. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Feb 9, 2022

rerun tests

1 similar comment
@ajschmidt8
Copy link
Member

rerun tests

@dantegd
Copy link
Member

dantegd commented Feb 10, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8838120 into rapidsai:branch-22.04 Feb 10, 2022
@jakirkham
Copy link
Member

Thanks all! 😄

vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@galipremsagar
Unpin max dask and distributed versions (rapidsai#4546)
8dbbbf0 
Changed to be in-line with: rapidsai/cudf#10182

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
conda conda issue gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@galipremsagar @ajschmidt8 @codecov-commenter @dantegd @jakirkham