Remove deprecated code #10124
Merged
Remove deprecated code #10124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
3 - Ready for Review
bdice
requested changes
Jan 25, 2022
|
+34, -471 is beautiful |
Now +99, -687 :) |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10124 +/- ##
================================================
+ Coverage 10.37% 10.45% +0.07%
================================================
Files 119 119
Lines 20149 20076 -73
================================================
+ Hits 2091 2099 +8
+ Misses 18058 17977 -81
Continue to review full report at Codecov.
|
bdice
reviewed
Jan 26, 2022
bdice
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
Nice work. I'll follow up on this in #10034 to use the new set_random_null_mask_inplace(sr) helper function in all tests (unless you're planning to do that in this PR - either way is fine). I think this PR is complete in its intended scope so I approve.
shwina
approved these changes
Jan 28, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
to rapidsai/cuspatial
that referenced
this pull request
Jan 28, 2022
Fix for breaking changes in rapidsai/cudf#10124. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Paul Taylor (https://github.com/trxcllnt) URL: #485
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 2, 2022
This PR cleans up some remaining places where `to_array` needs to be removed. Actual cleanup was done in: #10124 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Bradley Dice (https://github.com/bdice) URL: #10189
bdice
added a commit
to bdice/cudf
that referenced
this pull request
Feb 28, 2022
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 28, 2022
PR #10124 removed several deprecated methods. This PR also removes their documentation. cc: @vyasr Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ashwin Srinath (https://github.com/shwina) URL: #10366
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a large number of deprecated code paths in cuDF. This PR resolves #9465 and partially addresses #9828 (this PR does not address any mask-related API deprecations other than the removal of the already deprecated Series.set_mask).