Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPRECATION] Remove support for boolean masks in take #9465

Closed
vyasr opened this issue Oct 19, 2021 · 1 comment · Fixed by #10124
Closed

[DEPRECATION] Remove support for boolean masks in take #9465

vyasr opened this issue Oct 19, 2021 · 1 comment · Fixed by #10124
Assignees

Comments

@vyasr
Copy link
Contributor

vyasr commented Oct 19, 2021

The take method of various pandas objects is only designed to accept integer indices. We have also supported boolean masks up to now, but the preferred method to do this should be via iloc[mask]. Removing this helps us reduce the internal complexity of take.

@vyasr vyasr self-assigned this Oct 19, 2021
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

rapids-bot bot pushed a commit that referenced this issue Jan 28, 2022
This PR removes a large number of deprecated code paths in cuDF. This PR resolves #9465 and partially addresses #9828 (this PR does not address any mask-related API deprecations other than the removal of the already deprecated Series.set_mask).

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Ashwin Srinath (https://github.com/shwina)

URL: #10124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant