-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Deprecate Series.as_mask #9828
Comments
I think along with this we should think about what mask-related APIs we really should be exposing at the Python layer. For instance, should the |
I agree that many (all?) properties dealing with bitmasks could be considered implementation details for the Python API. The APIs I'm looking at are:
(edit: updated status of APIs) |
This PR adds doctests and resolves #9513. Several issues were found by running doctests that have now been resolved: - [x] #9821 - [x] #9822 - [x] #9823 - [x] #9824 - [x] #9825 - [x] #9826 - [x] #9827 - [x] #9828 (workaround by deleting doctests) - [x] #9829 Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ashwin Srinath (https://github.com/shwina) - Vyas Ramasubramani (https://github.com/vyasr) URL: #9815
This issue has been labeled |
This PR removes a large number of deprecated code paths in cuDF. This PR resolves #9465 and partially addresses #9828 (this PR does not address any mask-related API deprecations other than the removal of the already deprecated Series.set_mask). Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Bradley Dice (https://github.com/bdice) - Ashwin Srinath (https://github.com/shwina) URL: #10124
This issue has been labeled |
@shwina are you aware of any issues with proceeding here? @bdice's last comment shows what APIs still need to be updated. |
The comment above is still accurate. I think we can go ahead and remove these. |
Is your feature request related to a problem? Please describe.
Doctests (#9815) show the following doctest failing:
cudf/python/cudf/cudf/core/series.py
Lines 1783 to 1793 in 582cc6e
Describe the solution you'd like
From a preliminary discussion with @vyasr, we probably want to deprecate and remove
as_mask
from the public API.In the short term, I am removing the doctests for
Series.as_mask().to_host_array()
in #9815 (f881890) because it's somewhat untestable and not helpful to demonstrate to users if we deprecate and remove the feature. It appears that the buffer has a size of 64 bytes. I assume that's the smallest allocation RMM can give, but that's not obvious to users who look at the output data of the doctest. Furthermore, the doctest shows uninitialized (garbage) data in the output ofto_host_array()
which is misleading.The text was updated successfully, but these errors were encountered: