Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Remove DataFrame._repr_pandas025_formatting. #9824

Closed
Tracked by #9815
bdice opened this issue Dec 2, 2021 · 4 comments · Fixed by #9922
Closed
Tracked by #9815

[FEA] Remove DataFrame._repr_pandas025_formatting. #9824

bdice opened this issue Dec 2, 2021 · 4 comments · Fixed by #9922
Assignees
@vyasr
Labels
feature request New feature or request Python Affects Python cuDF API.

Comments

@bdice
Copy link
Contributor

bdice commented Dec 2, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
It appears that the function DataFrame._repr_pandas025_formatting is only called once, in a test:

cudf/python/cudf/cudf/tests/test_repr.py

Line 101 in 31f92d7

ncols, nrows = gdf._repr_pandas025_formatting(ncols, nrows, dtype)

It is failing a doctest (#9815) because the variable gdf is not defined:
https://github.com/bdice/cudf/blob/39a3050a200b7728def8bd2cc14bf27e8dbc9279/python/cudf/cudf/core/dataframe.py#L1687-L1704

Describe the solution you'd like
This function could be removed from the API of cudf.DataFrame and its logic could be implemented in the test code.
@bdice bdice added feature request New feature or request Python Affects Python cuDF API. tech debt labels Dec 2, 2021
@vyasr
Copy link
Contributor

vyasr commented Dec 2, 2021

I thought I had already addressed this. I think it must be in a branch that I haven't made a PR for yet, I'll push that out sometime before the next release.

@bdice bdice mentioned this issue Dec 2, 2021
Merged
9 tasks
@bdice
Copy link
Contributor Author

bdice commented Dec 15, 2021 •
edited
Loading

@vyasr If you have a branch removing this and want to push, that'd be helpful. We're getting down to the last few failures in #9815. (edit: if you don't have a branch, that's fine! I can fix it, just trying to prevent duplicate work.)

@vyasr
Copy link
Contributor

vyasr commented Dec 15, 2021

I should be able to get to this tomorrow.

@vyasr
Copy link
Contributor

vyasr commented Dec 16, 2021

I stitched together the changes from a few cleanup stashes/branches and pushed them to #9922, which should resolve this.

@vyasr vyasr mentioned this issue Dec 16, 2021
Merged
@rapids-bot rapids-bot bot closed this as completed in #9922 Jan 3, 2022
rapids-bot bot pushed a commit that referenced this issue Jan 3, 2022
@vyasr
Remove various unused functions (#9922)
7233765 
This PR removes a number of unused functions and inlines some helpers that are only called in one place. This PR also deprecates `Series.fill`, which does not appear to be a pandas API. This PR resolves #9824.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Ram (Ramakrishna Prabhu) (https://github.com/rgsl888prabhu)
  - Bradley Dice (https://github.com/bdice)

URL: #9922
rapids-bot bot pushed a commit that referenced this issue Jan 15, 2022
@bdice
Run doctests. (#9815)
e24fa8f 
This PR adds doctests and resolves #9513. Several issues were found by running doctests that have now been resolved:

- [x] #9821
- [x] #9822
- [x] #9823
- [x] #9824
- [x] #9825
- [x] #9826
- [x] #9827
- [x] #9828 (workaround by deleting doctests)
- [x] #9829

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Ashwin Srinath (https://github.com/shwina)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #9815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vyasr vyasr

Labels
feature request New feature or request Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove various unused functions vyasr/cudf
2 participants
@vyasr @bdice