Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Remove cleaned up methods from docs #10189

Merged
merged 2 commits into from
Feb 2, 2022
Merged

[REVIEW] Remove cleaned up methods from docs #10189

merged 2 commits into from
Feb 2, 2022

Conversation

galipremsagar
Copy link
Contributor

This PR cleans up some remaining places where to_array needs to be removed. Actual cleanup was done in: #10124

@galipremsagar galipremsagar added doc Documentation Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 2, 2022
@galipremsagar galipremsagar requested a review from vyasr February 2, 2022 16:04
@galipremsagar galipremsagar requested a review from a team as a code owner February 2, 2022 16:04
@galipremsagar galipremsagar self-assigned this Feb 2, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@galipremsagar galipremsagar removed the improvement Improvement / enhancement to an existing function label Feb 2, 2022
@galipremsagar galipremsagar removed the request for review from marlenezw February 2, 2022 16:17
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Feb 2, 2022
@codecov
Copy link

codecov bot commented Feb 2, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@8d2a9cc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04   #10189   +/-   ##
===============================================
  Coverage                ?   10.48%           
===============================================
  Files                   ?      122           
  Lines                   ?    20496           
  Branches                ?        0           
===============================================
  Hits                    ?     2148           
  Misses                  ?    18348           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d2a9cc...eced513. Read the comment docs.

@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a080a4c into rapidsai:branch-22.04 Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@vyasr vyasr Awaiting requested review from vyasr

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge doc Documentation non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @bdice