Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Java bindings for fixed-point Decimal type #6515

Closed
16 tasks done
sperlingxx opened this issue Oct 13, 2020 · 7 comments · Fixed by #6761 or #6734
Closed
16 tasks done

[FEA] Java bindings for fixed-point Decimal type #6515

sperlingxx opened this issue Oct 13, 2020 · 7 comments · Fixed by #6761 or #6734
Labels
feature request New feature or request Java Affects Java cuDF API.

Comments

@sperlingxx
Copy link
Contributor

sperlingxx commented Oct 13, 2020

Is your feature request related to a problem? Please describe.
cuDF Java API should be able to leverage new cuDF feature, fixed-point decimal type, in order to support decimal type in spark-rapids plugin (issue link).

Describe the solution you'd like
Initial Tasks

  • Add class DataType, and add Decimal32/64 into DType collection ([REVIEW] Initial work for decimal type in Java/JNI [skip ci] #6514)
    • Add class NativeDataType (which manages the handle of native data_type class)
    • Package-level adaption for Dtype -> DataType transformation (check all references of DType)
    • Scalar (scalar JNI, scalar building functions for decimalType)

Other Tasks

Additional context
Native Prerequisites

@sperlingxx sperlingxx added Needs Triage Need team to review and classify feature request New feature or request labels Oct 13, 2020
@harrism harrism removed the Needs Triage Need team to review and classify label Oct 13, 2020
kkraus14 pushed a commit that referenced this issue Oct 27, 2020
This partially addresses tasks from issue #6515.
The goal of this PR is to add DType class and make the necessary changes in Java/JNI code to support scale in DType.
nartal1 added a commit that referenced this issue Nov 13, 2020
This partially fixes #6515.
Added tests to make sure binary operations can be performed in cudf Java.
@revans2 revans2 reopened this Nov 13, 2020
@kkraus14
Copy link
Collaborator

kkraus14 commented Dec 3, 2020

Pushing this to 0.18

@kkraus14 kkraus14 added the Java Affects Java cuDF API. label Dec 3, 2020
@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@revans2
Copy link
Contributor

revans2 commented Mar 19, 2021

@sperlingxx how much is left for this to be done? I think it is almost all complete

@sperlingxx
Copy link
Contributor Author

@sperlingxx how much is left for this to be done? I think it is almost all complete

Yes, it is almost complete except some cuDF native tasks. Shall we close this issue?

@beckernick
Copy link
Member

Are the outstanding tasks mentioned in this issue covered by any other issues? If so, perhaps this can be closed.

@harrism
Copy link
Member

harrism commented Jul 20, 2021

@sameerz @sperlingxx can you respond to @beckernick 's question above?

@sameerz
Copy link
Contributor

sameerz commented Jul 22, 2021

The ORC read / write for decimal in cuio is done in per #7126 and can be followed up on with the JNI binding work. We need to create issues (if we do not already have them) for unary operators for fixed-point decimals and aggregation operators for fixed-point decimals.

The RAPIDS Spark tasks related to this issue are tracked in NVIDIA/spark-rapids#42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Java Affects Java cuDF API.
Projects
None yet
6 participants