-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Java bindings for fixed-point Decimal type #6515
Comments
This partially addresses tasks from issue #6515. The goal of this PR is to add DType class and make the necessary changes in Java/JNI code to support scale in DType.
This partially fixes #6515. Added tests to make sure binary operations can be performed in cudf Java.
Pushing this to 0.18 |
This issue has been labeled |
@sperlingxx how much is left for this to be done? I think it is almost all complete |
Yes, it is almost complete except some cuDF native tasks. Shall we close this issue? |
Are the outstanding tasks mentioned in this issue covered by any other issues? If so, perhaps this can be closed. |
@sameerz @sperlingxx can you respond to @beckernick 's question above? |
The ORC read / write for decimal in cuio is done in per #7126 and can be followed up on with the JNI binding work. We need to create issues (if we do not already have them) for unary operators for fixed-point decimals and aggregation operators for fixed-point decimals. The RAPIDS Spark tasks related to this issue are tracked in NVIDIA/spark-rapids#42 |
Is your feature request related to a problem? Please describe.
cuDF Java API should be able to leverage new cuDF feature, fixed-point decimal type, in order to support decimal type in spark-rapids plugin (issue link).
Describe the solution you'd like
Initial Tasks
Dtype -> DataType
transformation (check all references of DType)Other Tasks
Additional context
Native Prerequisites
fixed_point
Column Optimization (storescale
indata_type
) [skip ci] #5861)fixed_point
binary operations ([REVIEW] Enablefixed_point
binary operations #6528 [REVIEW] Removefixed_point
precise round #6544)The text was updated successfully, but these errors were encountered: