[REVIEW] Remove fixed_point precise round
#6544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codereport
added
3 - Ready for Review
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #6544 +/- ##
============================================
Coverage 83.12% 83.12%
============================================
Files 90 90
Lines 14824 14826 +2
============================================
+ Hits 12322 12324 +2
Misses 2502 2502
Continue to review full report at Codecov.
|
16 tasks
harrism
requested changes
Oct 18, 2020
Co-authored-by: Mark Harris <[email protected]>
Co-authored-by: Mark Harris <[email protected]>
harrism
approved these changes
Oct 20, 2020
4 tasks
nvdbaranec
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In working on the the
fixed_pointbinary operations (#6528), we realized the "precise rounding" that we implemented forfixed_pointadds increased complexity to implementing thebinary_operation::DIVthat would require non-trivial modifications tokernel.cppandoperations.h. We thererfore decided to revert these changes (this is consistent with the design of CNL) to avoid this complexity.