Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] type casting between fixed-point decimal and other numeric types #6486

Closed
sperlingxx opened this issue Oct 10, 2020 · 5 comments · Fixed by #6711
Closed

[FEA] type casting between fixed-point decimal and other numeric types #6486

sperlingxx opened this issue Oct 10, 2020 · 5 comments · Fixed by #6711
Assignees
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.

Comments

@sperlingxx
Copy link
Contributor

sperlingxx commented Oct 10, 2020

What is your question?
According to the checklist of issue 3556, we are able to cast to/from floats, ints and decimal with other precision/accuracy in cuDF. How can we achieve that?
cudf::logical_cast alone doesn't seem to be the right solution. For integer types, we can perform cudf::logicial_cast after rescaling fix_point data to zero. But how to deal with float_point types?
@codereport can you help to give some advice? Thanks!

@sperlingxx sperlingxx added Needs Triage Need team to review and classify question Further information is requested labels Oct 10, 2020
@harrism
Copy link
Member

harrism commented Oct 12, 2020

@codereport I unchecked the box next to

cast to/from floats, ints and decimal with other precision/accuracy

because I looked at cast_ops.cu and I see multiple CUDF_FAIL("Fixed point unary ops currently not supported");.

Casting between types is a unary operation. Apparently this is not implemented yet. Converting this issue into a feature request.

@harrism harrism added feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. and removed Needs Triage Need team to review and classify question Further information is requested labels Oct 12, 2020
@harrism
Copy link
Member

harrism commented Oct 12, 2020

Assigning to @codereport for 0.17.

@harrism harrism changed the title [QST] how to do type casting between fixed-point decimal and other numeric types [FEA] type casting between fixed-point decimal and other numeric types Oct 12, 2020
@sperlingxx
Copy link
Contributor Author

@codereport @harrism
May I ask about the progress on this issue? The release_0.3 of spark-rapids project heavily depends on this feature, so we really want to know when this feature will be ready.
Sorry for any disturbing :)

@codereport
Copy link
Contributor

I am wrapping up cudf::round and this will be next. Should be done before 0.17 is released.

@shwina shwina closed this as completed Nov 7, 2020
@shwina shwina reopened this Nov 7, 2020
@shwina
Copy link
Contributor

shwina commented Nov 7, 2020

Oops - apologies. Can someone please move this back to P0? @harrism @kkraus14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants