[REVIEW] Binary operations support for decimal type in cudf Java [skip ci] #6734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niranjan Artal <[email protected]>
nartal1
added
3 - Ready for Review
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
nartal1
commented
Nov 11, 2020
revans2
reviewed
Nov 11, 2020
revans2
reviewed
Nov 12, 2020
revans2
approved these changes
Nov 13, 2020
| @@ -25,6 +25,7 @@ | |||
| import ai.rapids.cudf.HostColumnVector.StructType; | |||
|
|
|||
| import java.io.File; | |||
| import java.math.BigDecimal; | |||
There was a problem hiding this comment.
nit: the only change to this file is an uneeded import now.
nartal1
added
5 - Ready to Merge
|
Thanks @revans2 for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially fixes #6515.
Added tests to make sure binary operations can be performed in cudf Java.