Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.13] backports for uberjar, Dev ui with HTTPS, local infinispan and mixing of tests #992

Merged
merged 6 commits into from
Jan 17, 2023

Conversation

fedinskiy
Copy link
Contributor

@fedinskiy fedinskiy commented Jan 13, 2023

Summary

depends on: #997

Backport of these PRs:
#987 (Verify, that uberjar can be built even with empty suffix)
#986 (Verify, that dev ui page can be updated via "browser" and HTTPS)
#984 (Add minimal coverage for local Infinispan and for working with DevMode)
#979 (Coverage for mixing @QuarkusMainTest and @QuarkusTest in the same package )

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

When option quarkus.package.add-runner-suffix=false is used,
überjar and the original JAR have the same name and the original JAR is
deleted before über is created.
Since über is created on the basis of original, this option caused failure,
before the fix in https://issues.redhat.com/browse/QUARKUS-2777
Add features, required to cover QUARKUS-2777 and QUARKUS-2748
…kage

Required for https://issues.redhat.com/browse/QUARKUS-2789
Names of the tests are important, see the first comment to the issue
@fedinskiy fedinskiy marked this pull request as ready for review January 17, 2023 10:35
@rsvoboda rsvoboda requested a review from pjgg January 17, 2023 12:01
@fedinskiy fedinskiy changed the title [2.13] new coverage backports [2.13] backports for uberjar, Dev ui with HTTPS, local infinispan and mixing of tests Jan 17, 2023
Copy link
Contributor

@pjgg pjgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjgg pjgg merged commit 30dc8ea into quarkus-qe:2.13 Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants