Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage for mixing @QuarkusMainTest and @QuarkusTest in the same package #979

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

fedinskiy
Copy link
Contributor

Summary

Required for https://issues.redhat.com/browse/QUARKUS-2789.
Names of the tests are important, see the first comment to the issue

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy fedinskiy requested a review from jsmrcka January 5, 2023 17:44
@fedinskiy fedinskiy force-pushed the feature/test-mixing branch 2 times, most recently from 58f01db to 2819794 Compare January 6, 2023 07:47
Copy link
Contributor

@jsmrcka jsmrcka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only a small readability addition suggested.

@jsmrcka
Copy link
Contributor

jsmrcka commented Jan 6, 2023

Actually, one more thing: the PR source branch is not coming from a fork, but directly from the upstream repo. It's probably not an issue, just pointing it out. 😄

…kage

Required for https://issues.redhat.com/browse/QUARKUS-2789
Names of the tests are important, see the first comment to the issue
@fedinskiy fedinskiy force-pushed the feature/test-mixing branch from 2819794 to 2381caf Compare January 6, 2023 15:55
@fedinskiy fedinskiy requested a review from jsmrcka January 6, 2023 15:56
@jsmrcka jsmrcka merged commit 74a160a into main Jan 6, 2023
@fedinskiy fedinskiy deleted the feature/test-mixing branch January 9, 2023 08:05
@pjgg pjgg added the triage/backport-2.13? It needs to backport changes to branch 2.13 label Jan 17, 2023
@fedinskiy fedinskiy removed the triage/backport-2.13? It needs to backport changes to branch 2.13 label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants