Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify, that dev ui page can be updated via "browser" and HTTPS #986

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Verify, that dev ui page can be updated via "browser" and HTTPS #986

merged 1 commit into from
Jan 13, 2023

Conversation

fedinskiy
Copy link
Contributor

Required for https://issues.redhat.com/browse/QUARKUS-2748

Is in draft stage, until we release a new version of the FW.

Summary

(Summarize the problem solved by this PR, and how to verify it manually)

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy fedinskiy requested review from michalvavrik and pjgg and removed request for michalvavrik January 12, 2023 13:49
pjgg
pjgg suggested changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@pjgg pjgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to wait to CI

...ttp-advanced-reactive/src/test/java/io/quarkus/ts/http/advanced/reactive/DevModeHttpsIT.java

@BeforeEach
void setUp() {
webClient = new WebClient();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT ?

new WebClient(BrowserVersion.FIREFOX);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? We do not really care, which implementation is used, and we prefer to use the most universal one. If you look for other usages in our code base (eg BaseMultiTenantSecurityIT or BaseWebappSecurityIT), you will notice, that we always use default constructor.

...ttp-advanced-reactive/src/test/java/io/quarkus/ts/http/advanced/reactive/DevModeHttpsIT.java Show resolved Hide resolved
@fedinskiy fedinskiy force-pushed the feature/https-dev-ui branch 2 times, most recently from 390bbd8 to 3204b0a Compare January 13, 2023 09:54
@fedinskiy fedinskiy force-pushed the feature/https-dev-ui branch from 3204b0a to 475eb46 Compare January 13, 2023 10:10
@fedinskiy fedinskiy requested a review from pjgg January 13, 2023 10:12
@fedinskiy fedinskiy marked this pull request as ready for review January 13, 2023 10:21
@fedinskiy fedinskiy added the triage/backport-2.13? It needs to backport changes to branch 2.13 label Jan 13, 2023
@fedinskiy fedinskiy mentioned this pull request Jan 13, 2023
Merged
9 tasks
pjgg
pjgg approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@pjgg pjgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedinskiy fedinskiy merged commit 2fad57f into quarkus-qe:main Jan 13, 2023
@fedinskiy fedinskiy removed the triage/backport-2.13? It needs to backport changes to branch 2.13 label Jan 17, 2023
michalvavrik
michalvavrik reviewed Jan 23, 2023
View reviewed changes
http/http-advanced-reactive/src/main/resources/application.properties
@@ -67,3 +67,5 @@ pl-container-request-filter.enabled=false
# Register MultipartFormDataReader as provider (used by io.quarkus.ts.http.advanced.reactive.MultipartResource.multipartFormData)
quarkus.index-dependency.resteasy-multipart.group-id=org.jboss.resteasy
quarkus.index-dependency.resteasy-multipart.artifact-id=resteasy-multipart-provider

quarkus.qe.test.value=42
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedinskiy @pjgg

I know we are Quarkus QE :-) but using quarkus.qe property prefix goes directly against docs https://quarkus.io/guides/config-reference#configuring_quarkus : As mentioned above, properties prefixed with quarkus. are effectively reserved for configuring Quarkus itself and its extensions. Therefore, the quarkus. prefix should never be used for application specific properties.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we change existing property instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik left review comments

@pjgg pjgg pjgg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedinskiy @pjgg @michalvavrik