Add minimal coverage for local Infinispan and for working with DevMode #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedinskiy
force-pushed
the
feature/devmode-infinspan
branch
2 times, most recently
from
4855a27 to
ec4a0e4
Compare
fedinskiy
added
the
triage/backport-2.13?
pjgg
suggested changes
Jan 11, 2023
nosql-db/infinispan/src/test/java/io/quarkus/ts/infinispan/InfinispanIT.java
Outdated
Show resolved
Hide resolved
| import javax.ws.rs.Path; | ||
|
|
||
| @Path("/first-counter") | ||
| public class FirstCounterResource extends InfinispanCounterResource { |
There was a problem hiding this comment.
I am not sure if this class is required or if we can just move the Path definition to InfinispanCounterResource
There was a problem hiding this comment.
This was copied from the infinispan-client module, so I may be wrong, but I presume this is required to guarantee, that we are addressing different beans
fedinskiy
force-pushed
the
feature/devmode-infinspan
branch
from
ec4a0e4 to
c85cea6
Compare
fedinskiy
force-pushed
the
feature/devmode-infinspan
branch
from
c85cea6 to
d39e523
Compare
fedinskiy
force-pushed
the
feature/devmode-infinspan
branch
from
d39e523 to
7c2ed5b
Compare
9 tasks
fedinskiy
removed
the
triage/backport-2.13?
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds coverage for a bug, encountered in https://issues.redhat.com/browse/QUARKUS-2747.
The separate module was created, since
application.propertiesfiles for this scenario and for scenarios ininfinispanmodule are not compatible and we cannot customise them with per-app granularity, because of quarkus-qe/quarkus-test-framework#174.The module has as little coverage as possible to minimise running time and consumed resources.
Please select the relevant options.
run testsphrase in comment)Checklist: