Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Via keymap to Spaceman 2% Milk #9484

Merged
merged 5 commits into from
Jul 29, 2020
Merged

Conversation

wongyuhao
Copy link
Contributor

@wongyuhao wongyuhao commented Jun 20, 2020

Description

Added Via keymap to support Spaceman 2% Milk

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keymap/layout/userspace (addition or update)
  • Keyboard (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 20, 2020
Merge from master branch
@drashna drashna requested a review from a team July 5, 2020 01:49
keyboards/spaceman/2_milk/config.h Outdated Show resolved Hide resolved
keyboards/spaceman/2_milk/keymaps/via/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team July 8, 2020 13:15
@keyboard-magpie
Copy link
Contributor

nudging @wongyuhao

@noroadsleft noroadsleft merged commit b3e7a4e into qmk:master Jul 29, 2020
@noroadsleft
Copy link
Member

Thanks!

Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Jul 31, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (156 commits)
  Add info.json for Jiran keyboard (qmk#9857)
  [Docs] Update Japanese translation of feature_ps2_mouse.md. (qmk#9815)
  [Docs] Update Japanese translation of feature_mouse_keys.md. (qmk#9809)
  [Keyboard] Add new keyboard ks63 handwired (qmk#9712)
  [keyboard] Add [n]2 support (qmk#9862)
  Timber Wolf - updated via keymap, reduced eeprom writing from backlight code (qmk#9876)
  [Docs] Update Japanese translation of feature_macros.md. (qmk#9767)
  [Keyboard] Add KPRepublic BM40HSRGB keyboard (qmk#9860)
  [Docs] Japanese translation of docs/internals_gpio_control.md (qmk#9751)
  [Docs] Japanese translation of docs/other_eclipse.md (qmk#9755)
  Added Via keymap to Spaceman 2% Milk (qmk#9484)
  Add via configuration for adelheid. (qmk#9830)
  Added Via-enabled keymap for Physix (qmk#9825)
  [Docs] Japanese translation of docs/one_shot_keys.md (qmk#9754)
  [Docs] Japanese translation of docs/mod_tap.md (qmk#9753)
  [Docs] Japanese translation of docs/how_keyboards_work.md (qmk#9683)
  [Docs] Japanese translation of docs/how_a_matrix_works.md (qmk#9682)
  [Keyboard] add bear_face/v2 (qmk#9642)
  [Keyboard] PH Arisu (qmk#9612)
  Timber Wolf - updated keymaps, fixed info.json (qmk#9787)
  ...
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
* added via support to spaceman 2% milk

* changed kc trns in layers 1-3

* changed vendor and product ID per creator suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants