Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Japanese translation of docs/other_eclipse.md #9755

Merged
merged 3 commits into from
Jul 30, 2020
Merged

[Docs] Japanese translation of docs/other_eclipse.md #9755

merged 3 commits into from
Jul 30, 2020

Conversation

umi-umi
Copy link
Contributor

@umi-umi umi-umi commented Jul 18, 2020

Description

Add a Japanese translation of docs/other_eclipse.md.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei
Copy link
Contributor

mtei commented Jul 18, 2020

@shelaf @s-show @hsgw @satt99 @takashiski @yoshihara よかったらレビューお願いします。

s-show
s-show reviewed Jul 20, 2020
View reviewed changes
docs/ja/other_eclipse.md Outdated Show resolved Hide resolved
s-show
s-show reviewed Jul 20, 2020
View reviewed changes
docs/ja/other_eclipse.md Outdated Show resolved Hide resolved
s-show
s-show reviewed Jul 20, 2020
View reviewed changes
docs/ja/other_eclipse.md Outdated Show resolved Hide resolved
s-show
s-show reviewed Jul 20, 2020
View reviewed changes
docs/ja/other_eclipse.md Outdated Show resolved Hide resolved
s-show
s-show reviewed Jul 20, 2020
View reviewed changes
docs/ja/other_eclipse.md Outdated Show resolved Hide resolved
@mtei mtei requested a review from a team July 21, 2020 16:36
shelaf
shelaf reviewed Jul 25, 2020
View reviewed changes
docs/ja/other_eclipse.md Outdated Show resolved Hide resolved
docs/ja/other_eclipse.md Outdated Show resolved Hide resolved
docs/ja/other_eclipse.md Outdated Show resolved Hide resolved
docs/ja/other_eclipse.md Outdated Show resolved Hide resolved
docs/ja/other_eclipse.md Outdated Show resolved Hide resolved
docs/ja/other_eclipse.md Outdated Show resolved Hide resolved
docs/ja/other_eclipse.md Outdated Show resolved Hide resolved
docs/ja/other_eclipse.md Outdated Show resolved Hide resolved
docs/ja/other_eclipse.md Outdated Show resolved Hide resolved
docs/ja/other_eclipse.md Outdated Show resolved Hide resolved
@mtei mtei requested a review from a team July 28, 2020 11:39
@mtei
Copy link
Contributor

mtei commented Jul 28, 2020

I think this is ready to merge.

noroadsleft
noroadsleft approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit de7da0b into qmk:master Jul 30, 2020
@noroadsleft
Copy link
Member

ありがとうございました！

Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Jul 31, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
a932d60 
* 'master' of https://github.com/qmk/qmk_firmware: (156 commits)
  Add info.json for Jiran keyboard (qmk#9857)
  [Docs] Update Japanese translation of feature_ps2_mouse.md. (qmk#9815)
  [Docs] Update Japanese translation of feature_mouse_keys.md. (qmk#9809)
  [Keyboard] Add new keyboard ks63 handwired (qmk#9712)
  [keyboard] Add [n]2 support (qmk#9862)
  Timber Wolf - updated via keymap, reduced eeprom writing from backlight code (qmk#9876)
  [Docs] Update Japanese translation of feature_macros.md. (qmk#9767)
  [Keyboard] Add KPRepublic BM40HSRGB keyboard (qmk#9860)
  [Docs] Japanese translation of docs/internals_gpio_control.md (qmk#9751)
  [Docs] Japanese translation of docs/other_eclipse.md (qmk#9755)
  Added Via keymap to Spaceman 2% Milk (qmk#9484)
  Add via configuration for adelheid. (qmk#9830)
  Added Via-enabled keymap for Physix (qmk#9825)
  [Docs] Japanese translation of docs/one_shot_keys.md (qmk#9754)
  [Docs] Japanese translation of docs/mod_tap.md (qmk#9753)
  [Docs] Japanese translation of docs/how_keyboards_work.md (qmk#9683)
  [Docs] Japanese translation of docs/how_a_matrix_works.md (qmk#9682)
  [Keyboard] add bear_face/v2 (qmk#9642)
  [Keyboard] PH Arisu (qmk#9612)
  Timber Wolf - updated keymaps, fixed info.json (qmk#9787)
  ...
@umi-umi umi-umi deleted the other_eclipse.md-japanese-translation branch August 9, 2020 09:09
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@umi-umi @nicocesar
[Docs] Japanese translation of docs/other_eclipse.md (qmk#9755)
84e6e66 
* add other_eclipse.md translation

* update based on comment

* update based on comment
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@umi-umi
[Docs] Japanese translation of docs/other_eclipse.md (qmk#9755)
f57b88a 
* add other_eclipse.md translation

* update based on comment

* update based on comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-show s-show s-show approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@mtei mtei mtei approved these changes

@shelaf shelaf shelaf approved these changes

Assignees
No one assigned
Labels
documentation translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@umi-umi @mtei @noroadsleft @shelaf @s-show