Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add new keyboard ks63 #9712

Merged
merged 32 commits into from
Jul 30, 2020
Merged

[Keyboard] Add new keyboard ks63 #9712

merged 32 commits into from
Jul 30, 2020

Conversation

klesh
Copy link
Contributor

@klesh klesh commented Jul 12, 2020

Description

A handwired 63 keys split keyboard compatible with Default 60% layout. Let you keep your magic power while muggles can still use it as an ordinary keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/handwired/ks63/README.md Outdated Show resolved Hide resolved
keyboards/handwired/ks63/ks63.h Outdated Show resolved Hide resolved
keyboards/handwired/ks63/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/ks63/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/ks63/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/ks63/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/ks63/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/ks63/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@zvecr zvecr added the keyboard label Jul 13, 2020
@zvecr zvecr requested a review from a team July 13, 2020 22:49
keyboards/handwired/ks63/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/ks63/README.md Outdated Show resolved Hide resolved
keyboards/handwired/ks63/README.md Outdated Show resolved Hide resolved
keyboards/handwired/ks63/config.h Outdated Show resolved Hide resolved
keyboards/handwired/ks63/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/ks63/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/ks63/rules.mk Outdated Show resolved Hide resolved
@klesh klesh requested review from fauxpark and zvecr July 29, 2020 16:21
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit 5d0c387 into qmk:master Jul 30, 2020
@noroadsleft
Copy link
Member

Thanks!

Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Jul 31, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (156 commits)
  Add info.json for Jiran keyboard (qmk#9857)
  [Docs] Update Japanese translation of feature_ps2_mouse.md. (qmk#9815)
  [Docs] Update Japanese translation of feature_mouse_keys.md. (qmk#9809)
  [Keyboard] Add new keyboard ks63 handwired (qmk#9712)
  [keyboard] Add [n]2 support (qmk#9862)
  Timber Wolf - updated via keymap, reduced eeprom writing from backlight code (qmk#9876)
  [Docs] Update Japanese translation of feature_macros.md. (qmk#9767)
  [Keyboard] Add KPRepublic BM40HSRGB keyboard (qmk#9860)
  [Docs] Japanese translation of docs/internals_gpio_control.md (qmk#9751)
  [Docs] Japanese translation of docs/other_eclipse.md (qmk#9755)
  Added Via keymap to Spaceman 2% Milk (qmk#9484)
  Add via configuration for adelheid. (qmk#9830)
  Added Via-enabled keymap for Physix (qmk#9825)
  [Docs] Japanese translation of docs/one_shot_keys.md (qmk#9754)
  [Docs] Japanese translation of docs/mod_tap.md (qmk#9753)
  [Docs] Japanese translation of docs/how_keyboards_work.md (qmk#9683)
  [Docs] Japanese translation of docs/how_a_matrix_works.md (qmk#9682)
  [Keyboard] add bear_face/v2 (qmk#9642)
  [Keyboard] PH Arisu (qmk#9612)
  Timber Wolf - updated keymaps, fixed info.json (qmk#9787)
  ...
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
* [feature] add ks63 split keyboard

* [bugfix] unable to compile and some rows are not working

* [feature] add info.json / update keymap

* [bugfix] keymap and fix slave not working issue

* [bugfix] keyboard unaviable on cold boot / unable to reset the board

* [misc] fine tune keymap

* [misc] fine tune keymap

* ...

* ...

* ...

* [misc] adjust brackets position

* [misc] add readme link

* [misc] comply to coding convention

* [misc] add default keymap readme file

* Update keyboards/handwired/ks63/README.md

* Update keyboards/handwired/ks63/ks63.h

* Update keyboards/handwired/ks63/keymaps/default/keymap.c

* Update keyboards/handwired/ks63/keymaps/default/keymap.c

* Update keyboards/handwired/ks63/keymaps/default/keymap.c

* Update keyboards/handwired/ks63/keymaps/default/keymap.c

* Update keyboards/handwired/ks63/keymaps/default/keymap.c

* Update keyboards/handwired/ks63/keymaps/default/keymap.c

* Update keyboards/handwired/ks63/rules.mk

* Update keyboards/handwired/ks63/README.md

* Update keyboards/handwired/ks63/keymaps/default/keymap.c

* [misc] to lowercase filename

* Update keyboards/handwired/ks63/rules.mk

* Update keyboards/handwired/ks63/rules.mk

* Update keyboards/handwired/ks63/config.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants