Support IS31FL3741 and IS31FL3741A.

[melgeek001365]

Description

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

• Closes add support for IS31FL3741 #6101

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[fauxpark]

Please do not close this PR, you are making it more difficult to review.

You may be asked to make changes, which you can do either by accepting the suggestions a reviewer may make, or by committing and pushing to the melgeek branch - the PR will be updated here with the additional commits. There is no need to close and reopen it every time.

[melgeek001365]

Please do not close this PR, you are making it more difficult to review.

You may be asked to make changes, which you can do either by accepting the suggestions a reviewer may make, or by committing and pushing to the melgeek branch - the PR will be updated here with the additional commits. There is no need to close and reopen it every time.

BTW, I have two commits with the melgeek branch. but it will be merge one PR with two commits automatically. how can I handle it ?

[fauxpark]

You will need to create a separate branch and PR for the keyboard addition.

[melgeek001365]

You will need to create a separate branch and PR for the keyboard addition.

OK. Thank you very much! I will do it.

@fauxpark Hey. I have gave it a try. and found that If I create a new branch for Z70Ultra it will including the first commit of ISSI3741. what should I do?

[fauxpark]

Don't branch off of the melgeek branch, go back to master and create the branch from there:

master
     |---> melgeek
     \---> z70ultra

For example.

[melgeek001365]

Don't branch off of the melgeek branch, go back to master and create the branch from there:

master
     |---> melgeek
     \---> z70ultra

For example.

Done. Thank you! but I think the Travis CI will be failed, Cause it not including the 3741 driver.

[elfmimi]

This PR should also solve issue #6101 .

[drashna]

This PR should also solve issue #6101 .

Yup, looks like it, and that's tagged in the op. Should close the issue when it's merged.

[rea104]

Hello, IS31Fl3741 has an Open/Short detection functionality. Has anyone tried it?
I'm trying to implement a couple of "diagnose" function to locate problems on a specific LED, but I can't manage to make the IS31FL3741 behave as indicated in the datasheet.

[elfmimi]

@rea104 it is okay to start a new issue if it is a technically reasonable one like this. so please don't post it randomly.

[myst729]

@melgeek001365 I have read your Z70Ultra firmware, and I noticed that you defined 1 driver and 2 driver addresses (same value) for compliancy reasons, which is not explained anywhere else. And what addresses are available (since each driver is a little different from others)?

I'm trying to light an Adafruit IS31FL3741 breakout board (open sourced here) with a Pro Micro via I2C, but still have no luck. Could you add a doc section in RGB Matrix Lighting page?

[fauxpark]

Until fairly recently the RGB Matrix code for certain ISSI LED drivers assumed two of them were present, even if you only had one on the actual PCB. This has now been fixed to allow from 1 to 4 drivers to be defined, however the IS31FL3741 code still only supports a single driver. So for that specific board it is probably due to copypaste.

I've opened a PR to clean this up a bit further: #14760