Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 4x12 #9411

Merged
merged 4 commits into from
Jun 16, 2020
Merged

added 4x12 #9411

merged 4 commits into from
Jun 16, 2020

Conversation

daysgobye
Copy link
Contributor

@daysgobye daysgobye commented Jun 14, 2020

Description

added keyboard 4x12 to the boardsource folder

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/boardsource/4x12/rules.mk Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team June 14, 2020 12:39
@fauxpark fauxpark requested a review from a team June 14, 2020 18:34
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the board supports the ortho 4x12 community layout.

keyboards/boardsource/4x12/4x12.h Outdated Show resolved Hide resolved
keyboards/boardsource/4x12/info.json Outdated Show resolved Hide resolved
keyboards/boardsource/4x12/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/boardsource/4x12/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/boardsource/4x12/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/boardsource/4x12/rules.mk Show resolved Hide resolved
@daysgobye
Copy link
Contributor Author

this keyboard does not have back-lighting I and it is not enabled in the rules.mk I am not sure why the build is failing, it does not seem to fail on my computer. Should I define a unused pin as a backlight pin?

@Erovia Erovia merged commit 80b2b71 into qmk:master Jun 16, 2020
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Jun 18, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (36 commits)
  [Keyboard] Jian keyboard (qmk#8914)
  Implement game mode layer for dcompact on planck (qmk#9402)
  [Keymap] new keymap for XD75 (qmk#8675)
  Clean up Tap Dance docs (qmk#9372)
  CLI: Add ATmega328 and ATtiny85 to supported CPUs (qmk#9371)
  Fix error_log complaint about clueboard/66_hotswap/gen1 layout macro (qmk#9400)
  Nebula65 (qmk#9368)
  added 4x12 (qmk#9411)
  [Keymap] Add froggy keymap with 106/109 (JP) settings for helix keyboard (qmk#8967)
  [Keymap] csc027/keymap-updates (qmk#9420)
  Add VIA support to keebio/nyquist (qmk#9399)
  [Keymap] Drashna's Keymap Update - Display Edition (qmk#9282)
  [Keymap] Add "shwilliam" Preonic keymap (qmk#9409)
  HID Liberation Device Refactor and Configurator layout support (qmk#9394)
  [Keyboard] Fix Configurator layout data for handwired/1800fl (qmk#9393)
  [Keyboard] Fix Configurator layout data for acheron/elongate (qmk#9392)
  Change ?= to = in keyboard rules.mk (qmk#9390)
  [Docs] Fix link to mod_tap.md in the one_shot_keys.md file (qmk#9380)
  [Keyboard] Hub16 keymap bugfix (qmk#9345)
  [Keyboard] Add Eon75 (qmk#9333)
  ...
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants