Clean up Tap Dance docs #9372
Merged
Clean up Tap Dance docs #9372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmwphd
suggested changes
Jun 12, 2020
There was a problem hiding this comment.
Looks good to me, except that in line 330, :id=example-5-using-tap-dance-for-advanced-mod-tap-and-layer-tap-keys shows up in the rendered Markdown. It's the only header with an :id appended like that and I'm not sure why. Could be some restriction on id-ing headers of level 4 rather than 3?
|
That's normal; it's for translation purposes, since the heading links in Docsify are otherwise autogenerated from the heading text: https://docsify.now.sh/helpers?id=customise-id-for-headings I should probably fill the rest of them in, though. |
rmwphd
approved these changes
Jun 12, 2020
Another trick is, if you check out the code changes, you can run |
drashna
approved these changes
Jun 15, 2020
|
Thanks! |
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Jun 18, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (36 commits) [Keyboard] Jian keyboard (qmk#8914) Implement game mode layer for dcompact on planck (qmk#9402) [Keymap] new keymap for XD75 (qmk#8675) Clean up Tap Dance docs (qmk#9372) CLI: Add ATmega328 and ATtiny85 to supported CPUs (qmk#9371) Fix error_log complaint about clueboard/66_hotswap/gen1 layout macro (qmk#9400) Nebula65 (qmk#9368) added 4x12 (qmk#9411) [Keymap] Add froggy keymap with 106/109 (JP) settings for helix keyboard (qmk#8967) [Keymap] csc027/keymap-updates (qmk#9420) Add VIA support to keebio/nyquist (qmk#9399) [Keymap] Drashna's Keymap Update - Display Edition (qmk#9282) [Keymap] Add "shwilliam" Preonic keymap (qmk#9409) HID Liberation Device Refactor and Configurator layout support (qmk#9394) [Keyboard] Fix Configurator layout data for handwired/1800fl (qmk#9393) [Keyboard] Fix Configurator layout data for acheron/elongate (qmk#9392) Change ?= to = in keyboard rules.mk (qmk#9390) [Docs] Fix link to mod_tap.md in the one_shot_keys.md file (qmk#9380) [Keyboard] Hub16 keymap bugfix (qmk#9345) [Keyboard] Add Eon75 (qmk#9333) ...
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
* Clean up Tap Dance docs * Add heading IDs for translation
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Clean up Tap Dance docs * Add heading IDs for translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mostly fixing code style, removing references to the deprecated
ACTION_FUNCTION_TAPand trying to clarify the simple example (in particular, where to put theTD()keycode).Types of Changes
Issues Fixed or Closed by This PR
Checklist