Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement game mode layer for dcompact on planck #9402

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Implement game mode layer for dcompact on planck #9402

merged 1 commit into from
Jun 18, 2020

Conversation

loksonarius
Copy link
Contributor

@loksonarius loksonarius commented Jun 13, 2020 •
edited
Loading

Description

Adding a Game mode layer to my keymap on the Planck

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team June 15, 2020 10:17
@drashna drashna added the keymap label Jun 15, 2020
@noroadsleft noroadsleft merged commit 39ff121 into qmk:master Jun 18, 2020
@noroadsleft
Copy link
Member

Thanks!

Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Jun 18, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
b93d5c8 
* 'master' of https://github.com/qmk/qmk_firmware: (36 commits)
  [Keyboard] Jian keyboard (qmk#8914)
  Implement game mode layer for dcompact on planck (qmk#9402)
  [Keymap] new keymap for XD75 (qmk#8675)
  Clean up Tap Dance docs (qmk#9372)
  CLI: Add ATmega328 and ATtiny85 to supported CPUs (qmk#9371)
  Fix error_log complaint about clueboard/66_hotswap/gen1 layout macro (qmk#9400)
  Nebula65 (qmk#9368)
  added 4x12 (qmk#9411)
  [Keymap] Add froggy keymap with 106/109 (JP) settings for helix keyboard (qmk#8967)
  [Keymap] csc027/keymap-updates (qmk#9420)
  Add VIA support to keebio/nyquist (qmk#9399)
  [Keymap] Drashna's Keymap Update - Display Edition (qmk#9282)
  [Keymap] Add "shwilliam" Preonic keymap (qmk#9409)
  HID Liberation Device Refactor and Configurator layout support (qmk#9394)
  [Keyboard] Fix Configurator layout data for handwired/1800fl (qmk#9393)
  [Keyboard] Fix Configurator layout data for acheron/elongate (qmk#9392)
  Change ?= to = in keyboard rules.mk (qmk#9390)
  [Docs] Fix link to mod_tap.md in the one_shot_keys.md file (qmk#9380)
  [Keyboard] Hub16 keymap bugfix (qmk#9345)
  [Keyboard] Add Eon75 (qmk#9333)
  ...
@loksonarius loksonarius deleted the dcompact/plank-game-mode branch June 23, 2020 00:04
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@loksonarius @jakobaa
Implement game mode layer for dcompact on planck (qmk#9402)
48243ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@loksonarius @noroadsleft @drashna @fauxpark