Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add ATmega328 and ATtiny85 to supported CPUs #9371

Merged
merged 2 commits into from
Jun 17, 2020

Conversation

Erovia
Copy link
Member

@Erovia Erovia commented Jun 11, 2020

Description

Support for ATmega328 was added in #9043.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Support for ATmega328 was added in qmk#9043.
@Erovia Erovia added cli qmk cli command python labels Jun 11, 2020
@Erovia Erovia requested a review from a team June 11, 2020 07:46
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also look at qmk/qmk_compiler#72

lib/python/qmk/constants.py Outdated Show resolved Hide resolved
@Erovia Erovia requested a review from fauxpark June 11, 2020 20:24
@zvecr zvecr requested a review from a team June 11, 2020 20:37
@drashna drashna requested a review from a team June 15, 2020 09:43
@noroadsleft noroadsleft changed the title CLI: Add ATmega328 to supported CPUs CLI: Add ATmega328 and ATtiny85 to supported CPUs Jun 17, 2020
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit a0bf235 into qmk:master Jun 17, 2020
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Jun 18, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (36 commits)
  [Keyboard] Jian keyboard (qmk#8914)
  Implement game mode layer for dcompact on planck (qmk#9402)
  [Keymap] new keymap for XD75 (qmk#8675)
  Clean up Tap Dance docs (qmk#9372)
  CLI: Add ATmega328 and ATtiny85 to supported CPUs (qmk#9371)
  Fix error_log complaint about clueboard/66_hotswap/gen1 layout macro (qmk#9400)
  Nebula65 (qmk#9368)
  added 4x12 (qmk#9411)
  [Keymap] Add froggy keymap with 106/109 (JP) settings for helix keyboard (qmk#8967)
  [Keymap] csc027/keymap-updates (qmk#9420)
  Add VIA support to keebio/nyquist (qmk#9399)
  [Keymap] Drashna's Keymap Update - Display Edition (qmk#9282)
  [Keymap] Add "shwilliam" Preonic keymap (qmk#9409)
  HID Liberation Device Refactor and Configurator layout support (qmk#9394)
  [Keyboard] Fix Configurator layout data for handwired/1800fl (qmk#9393)
  [Keyboard] Fix Configurator layout data for acheron/elongate (qmk#9392)
  Change ?= to = in keyboard rules.mk (qmk#9390)
  [Docs] Fix link to mod_tap.md in the one_shot_keys.md file (qmk#9380)
  [Keyboard] Hub16 keymap bugfix (qmk#9345)
  [Keyboard] Add Eon75 (qmk#9333)
  ...
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* CLI: Add ATmega328 to supported CPUs

Support for ATmega328 was added in qmk#9043.

* Update lib/python/qmk/constants.py
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Aug 9, 2020
* CLI: Add ATmega328 to supported CPUs

Support for ATmega328 was added in qmk#9043.

* Update lib/python/qmk/constants.py
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* CLI: Add ATmega328 to supported CPUs

Support for ATmega328 was added in qmk#9043.

* Update lib/python/qmk/constants.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants