gBoards Common #8921
Merged
gBoards Common #8921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 26, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
drashna
requested changes
Apr 29, 2020
|
Also, it looks like there are a bunch of formatting issues. If you could run a formatting pass. You can use the |
Co-Authored-By: Drashna Jaelre <[email protected]>
drashna
approved these changes
Apr 29, 2020
nooges
approved these changes
May 4, 2020
bitherder
pushed a commit
to bitherder/qmk_firmware
that referenced
this pull request
May 15, 2020
Co-Authored-By: Drashna Jaelre <[email protected]>
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
May 24, 2020
Co-Authored-By: Drashna Jaelre <[email protected]>
turky
pushed a commit
to turky/qmk_firmware
that referenced
this pull request
Jun 13, 2020
Co-Authored-By: Drashna Jaelre <[email protected]>
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
Co-Authored-By: Drashna Jaelre <[email protected]>
sjmacneil
pushed a commit
to sjmacneil/qmk_firmware
that referenced
this pull request
Feb 19, 2021
Co-Authored-By: Drashna Jaelre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part one of the gboards-consolidation project. The Mega PR has been separated out into smaller per-keyboard PRs.
This PR contains the common parts of the refactor project as per @zvecr . It contains many files used for the .def generation that the keymaps use at compile time, as well as the source JSON dicts and generator code. As well the existing gBoards have been removed from master to consolidate them into a single namespace
Types of Changes
Issues Fixed or Closed by This PR
Replaces #8262