Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gBoards BuzzSaw #8923

Closed
wants to merge 6 commits into from
Closed

gBoards BuzzSaw #8923

wants to merge 6 commits into from

Conversation

germ
Copy link
Contributor

@germ germ commented Apr 26, 2020

Part two of the gboards-consolidation project. The Mega PR has been separated out into smaller per-keyboard PRs.

This PR contains a single keyboard as per @zvecr , in this case BuzzSaw. This code was pulled from #8262

  • Enhancement/optimization
  • Keymap/layout/userspace (addition or update)

Issues Fixed or Closed by This PR

@zvecr zvecr added the awaiting_pr Relies on another PR to be merged first label Apr 26, 2020
keyboards/gboards/k/buzzsaw/buzzsaw.c Outdated Show resolved Hide resolved
keyboards/gboards/k/buzzsaw/config.h Outdated Show resolved Hide resolved
keyboards/gboards/k/buzzsaw/matrix.c Outdated Show resolved Hide resolved
@zvecr zvecr removed the awaiting_pr Relies on another PR to be merged first label May 4, 2020
@stale
Copy link

stale bot commented Jun 19, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@germ
Copy link
Contributor Author

germ commented Jun 22, 2020

What's holding this back?

@drashna drashna requested a review from a team July 8, 2020 13:03
@stale stale bot removed the awaiting changes label Jul 8, 2020
@drashna drashna added the breaking_change Changes that need to wait for a version increment label Jul 8, 2020
@Erovia
Copy link
Member

Erovia commented Jul 9, 2020

What's holding this back?

Mostly the lack of resources to review PRs.

But from a quick glance, I'd recommend the same things as I did for #8928.

  • modernize pin initialization

  • check if custom matrix is really needed, if yes, check if custom matrix lite is enough

Btw, this is a new (to QMK) board, right?

@drashna drashna changed the base branch from master to develop July 28, 2020 05:30
#define DEVICE_VER 0x0001
#define MANUFACTURER g Heavy Industries
#define PRODUCT BuzzSaw
#define DESCRIPTION Crouching Alice, Hidden Gergo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define DESCRIPTION Crouching Alice, Hidden Gergo

Comment on lines +31 to +36
#define LAYOUT_buzzsaw(N00, N01, N02, N03, N04, N05, N06, N07, N08, N09, N10, N11, N12, N13, N14, A01, L00, L01, L02, L03, L04, L05, R00, R01, R02, R03, R04, R05, R06, R07, A02, L10, L11, L12, L13, L14, L15, R10, R11, R12, R13, R14, R15, R16, A03, L20, L21, L22, L23, L24, L25, R20, R21, R22, R23, R24, R25, K00, L30, L31, L32, L33, R30, R31, K01, K02, K03) \
{ \
{N06, KC_NO, KC_NO, KC_NO, KC_NO}, {N05, L05, L15, L25, KC_NO}, {N04, L04, L14, L24, KC_NO}, {N03, L03, L13, L23, L33}, {N02, L02, L12, L22, L32}, {N01, L01, L11, L21, L31}, {N00, L00, L10, L20, L30}, \
\
{N07, R00, R10, R20, R30}, {N08, R01, R11, R21, R31}, {N09, R02, R12, R22, K01}, {N10, R03, R13, R23, K02}, {N11, R04, R14, R24, K03}, {N12, R05, R15, R25, KC_NO}, {N13, R06, R16, K00, KC_NO}, {N14, R07, A03, KC_NO, KC_NO}, {A01, A02, KC_NO, KC_NO, KC_NO}, \
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define LAYOUT_buzzsaw(N00, N01, N02, N03, N04, N05, N06, N07, N08, N09, N10, N11, N12, N13, N14, A01, L00, L01, L02, L03, L04, L05, R00, R01, R02, R03, R04, R05, R06, R07, A02, L10, L11, L12, L13, L14, L15, R10, R11, R12, R13, R14, R15, R16, A03, L20, L21, L22, L23, L24, L25, R20, R21, R22, R23, R24, R25, K00, L30, L31, L32, L33, R30, R31, K01, K02, K03) \
{ \
{N06, KC_NO, KC_NO, KC_NO, KC_NO}, {N05, L05, L15, L25, KC_NO}, {N04, L04, L14, L24, KC_NO}, {N03, L03, L13, L23, L33}, {N02, L02, L12, L22, L32}, {N01, L01, L11, L21, L31}, {N00, L00, L10, L20, L30}, \
\
{N07, R00, R10, R20, R30}, {N08, R01, R11, R21, R31}, {N09, R02, R12, R22, K01}, {N10, R03, R13, R23, K02}, {N11, R04, R14, R24, K03}, {N12, R05, R15, R25, KC_NO}, {N13, R06, R16, K00, KC_NO}, {N14, R07, A03, KC_NO, KC_NO}, {A01, A02, KC_NO, KC_NO, KC_NO}, \
}
#define LAYOUT_buzzsaw( \
N00, N01, N02, N03, N04, N05, N06, N07, N08, N09, N10, N11, N12, N13, N14, A01, \
L00, L01, L02, L03, L04, L05, R00, R01, R02, R03, R04, R05, R06, R07, A02, \
L10, L11, L12, L13, L14, L15, R10, R11, R12, R13, R14, R15, R16, A03, \
L20, L21, L22, L23, L24, L25, R20, R21, R22, R23, R24, R25, K00, \
L30, L31, L32, L33, R30, R31, K01, K02, K03 \
) { \
{ N06, KC_NO, KC_NO, KC_NO, KC_NO }, \
{ N05, L05, L15, L25, KC_NO }, \
{ N04, L04, L14, L24, KC_NO }, \
{ N03, L03, L13, L23, L33 }, \
{ N02, L02, L12, L22, L32 }, \
{ N01, L01, L11, L21, L31 }, \
{ N00, L00, L10, L20, L30 }, \
\
{ N07, R00, R10, R20, R30 }, \
{ N08, R01, R11, R21, R31 }, \
{ N09, R02, R12, R22, K01 }, \
{ N10, R03, R13, R23, K02 }, \
{ N11, R04, R14, R24, K03 }, \
{ N12, R05, R15, R25, KC_NO }, \
{ N13, R06, R16, K00, KC_NO }, \
{ N14, R07, A03, KC_NO, KC_NO }, \
{ A01, A02, KC_NO, KC_NO, KC_NO } \
}

@noroadsleft noroadsleft deleted the branch qmk:develop November 28, 2020 20:02
@tzarc tzarc reopened this Nov 28, 2020
@tzarc tzarc closed this Feb 27, 2021
@tzarc tzarc deleted the branch qmk:develop February 27, 2021 20:27
@noroadsleft noroadsleft reopened this Feb 27, 2021
@tzarc tzarc added the stale Issues or pull requests that have become inactive without resolution. label Nov 5, 2021
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jun 18, 2022
@keyboard-magpie
Copy link
Contributor

Germ sadly seems to have left the keyboard world for now, I think closing this for now until some other community member has the energy to take this up again is best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change Changes that need to wait for a version increment keyboard keymap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants