gBoards FaunchPad

[germ]

Part two of the gboards-consolidation project. The Mega PR has been separated out into smaller per-keyboard PRs.

This PR contains a single keyboard as per @zvecr , in this case FaunchPad. This code was pulled from #8262

• Enhancement/optimization
• Keymap/layout/userspace (addition or update)

Issues Fixed or Closed by This PR

• Replaces Gboards Consolidation #8262
• Waiting on gBoards Common  #8921

[drashna]

And a qmk cformat pass would be nice.

[stale]

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

[germ]

What's holding this back?

[Erovia]

What's holding this back?

Mostly the lack of resources to review PRs.

But from a quick glance, I'd recommend the same things as I did for #8928.

• modernize pin initialization

• check if custom matrix is really needed, if yes, check if custom matrix lite is enough

Btw, this is a new (to QMK) board, right?

[germ]

Makes sense, I'll see what I can do about the updated interface but the main reason I'm avoid it is simply lack of time due to COVID related backlog and I need to refactor/test 9 boards. :P

This is a new board though, same with Ginny. The Split boards operate just like the ergoDox, so anything that would work for it will work for my splits

[Erovia]

No worries, somehow life is quite busy for everybody right now, I wonder why.... :D

Since this is a new board, I removed the breaking_change tag, so that's at least -1 concern.

[germ]

As far as custom matrix goes, by the looks of it I'll need that (same as the EZ guys). I can work on migrating to the new lite code when I have a chance (and that will help clean up the code a bunch).

As far as the other recommendations I'll try and get those in soon

[noroadsleft]

Additionally, references to files in the g/ directory should be fixed. edit: never mind that

[noroadsleft]

Suggested change

	#define DEVICE_VER 1
	#define DEVICE_VER 0x0001

[noroadsleft]

Suggested change

#define DESCRIPTION Teeny Toiny Macropad

[noroadsleft]

Suggested change

	#define LAYOUT_faunch(k00, k01, k02, k03, k10, k11, k12, k13) \
	{ {k00, k01, k02, k03}, {k10, k11, k12, k13}, }
	#define LAYOUT_ortho_2x4( \
	k00, k01, k02, k03, \
	k10, k11, k12, k13 \
	) { \
	{ k00, k01, k02, k03 }, \
	{ k10, k11, k12, k13 } \
	}

[noroadsleft]

Suggested change

	[0] = LAYOUT_faunch( KC_1, KC_2, KC_3, KC_4,
	KC_5, KC_6, KC_7, KC_8)
	[0] = LAYOUT_ortho_2x4(
	KC_1, KC_2, KC_3, KC_4,
	KC_5, KC_6, KC_7, KC_8
	)

[noroadsleft]

Suggested change

	[0] = LAYOUT_faunch( KC_1, KC_2, KC_3, KC_4,
	KC_5, KC_6, KC_7, KC_8),
	[1] = LAYOUT_faunch( KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS,
	KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS)
	[0] = LAYOUT_ortho_2x4(
	KC_1, KC_2, KC_3, KC_4,
	KC_5, KC_6, KC_7, KC_8
	),
	[1] = LAYOUT_ortho_2x4(
	KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS,
	KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS
	),
	[2] = LAYOUT_ortho_2x4(
	KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS,
	KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS
	),
	[3] = LAYOUT_ortho_2x4(
	KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS,
	KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS
	)

[stale]

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

[Frenzie]

Fwiw, works great on my Faunchpad.

[stale]

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.