Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gBoards ErgoTaco #8924

Closed
wants to merge 5 commits into from
Closed

gBoards ErgoTaco #8924

wants to merge 5 commits into from

Conversation

germ
Copy link
Contributor

@germ germ commented Apr 26, 2020

Part two of the gboards-consolidation project. The Mega PR has been separated out into smaller per-keyboard PRs.

This PR contains a single keyboard as per @zvecr , in this case ErgoTaco. This code was pulled from #8262

  • Enhancement/optimization
  • Keymap/layout/userspace (addition or update)

Issues Fixed or Closed by This PR

@zvecr zvecr added the awaiting_pr Relies on another PR to be merged first label Apr 26, 2020
keyboards/gboards/k/ergotaco/matrix.c Outdated Show resolved Hide resolved
@zvecr zvecr added keyboard and removed awaiting_pr Relies on another PR to be merged first labels May 4, 2020
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on discord, personally I would like to avoid the k parent folder.

Also while this PR doesnt yet touch keyboards/ergotaco, relocating boards currently has to target breaking changes.

@zvecr zvecr added the breaking_change Changes that need to wait for a version increment label May 4, 2020
@germ germ requested review from zvecr and drashna May 5, 2020 01:43
@drashna drashna changed the base branch from master to develop July 28, 2020 05:33
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft requested a review from a team August 12, 2020 18:23
#define PRODUCT_ID 0x0005
#define DEVICE_VER 0x0001
#define MANUFACTURER g Heavy Industries
#define PRODUCT ErgoTaco
#define DESCRIPTION QMK keyboard firmware for ErgoTaco
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define DESCRIPTION QMK keyboard firmware for ErgoTaco

@qmk qmk locked and limited conversation to collaborators Nov 28, 2020
@qmk qmk unlocked this conversation Nov 28, 2020
@tzarc tzarc reopened this Nov 28, 2020
@tzarc tzarc closed this Feb 27, 2021
@tzarc tzarc deleted the branch qmk:develop February 27, 2021 20:27
@noroadsleft noroadsleft reopened this Feb 27, 2021
@tzarc tzarc added the stale Issues or pull requests that have become inactive without resolution. label Nov 5, 2021
@zvecr
Copy link
Member

zvecr commented Apr 6, 2022

Thank you for your contribution!

This pull request has been automatically closed because it has not had activity in the last 30 days.
Please feel free to give a status update now, ping for review, or re-open when it's ready.

@stale stale bot removed the stale Issues or pull requests that have become inactive without resolution. label Apr 6, 2022
@zvecr zvecr closed this Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change Changes that need to wait for a version increment keyboard keymap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants