Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Japanese translation of docs/feature_command.md #8672

Merged
merged 2 commits into from
Apr 20, 2020

Conversation

umi-umi
Copy link
Contributor

@umi-umi umi-umi commented Apr 4, 2020

Description

Add a Japanese translation of docs/feature_command.md.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@umi-umi umi-umi changed the title Japanese translation of docs/feature_command.md [Docs] Japanese translation of docs/feature_command.md Apr 4, 2020
docs/ja/feature_command.md Outdated Show resolved Hide resolved
@mtei
Copy link
Contributor

mtei commented Apr 6, 2020

@shelaf @s-show @hsgw よかったらレビューお願いします。

git diff 0.8.94 HEAD -- docs/feature_command.md | cat
-->

以前はマジックとして知られていたコマンドは、[ブートマジック](ja/feature_bootmagic.md)を使うために書き込みをしたりプラグを抜いたりすることなくキーボードの挙動を変更する方法です。この機能と[ブートマジックキーコード](feature_bootmagic.md#keycodes)には多くの重複があります。可能な限り、コマンドでは無くブートマジックキーコードの機能を使うことをお勧めします。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

まず、to flashとunplug以降は分けて読むべきだと考えます。bootmagicはキーボードの電源ON時に特定のキーを押し続けておく必要があるので、「使うために」の訳で合っていると思います。

Suggested change
以前はマジックとして知られていたコマンドは、[ブートマジック](ja/feature_bootmagic.md)を使うために書き込みをしたりプラグを抜いたりすることなくキーボードの挙動を変更する方法です。この機能と[ブートマジックキーコード](feature_bootmagic.md#keycodes)には多くの重複があります。可能な限り、コマンドでは無くブートマジックキーコードの機能を使うことをお勧めします。
以前はマジックとして知られていたコマンドは、ファームウェアを書き込んだり、[ブートマジック](ja/feature_bootmagic.md)を使うためにプラグを抜いたりすることなくキーボードの挙動を変更する方法です。この機能と[ブートマジックキーコード](feature_bootmagic.md#keycodes)には多くの重複があります。可能な限り、コマンドでは無くブートマジックキーコードの機能を使うことをお勧めします。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

訳例ありがとうございます。
ここは訳してて構造がいまいち掴み辛くて、

Command is a way
to change your keyboard's behavior 
  without having 
    to
      flash 
      or
      unplug it
  to use Bootmagic (changeを修飾するためのto)

みたいな感じに自分を説得していました。
ありがとうございます。

docs/ja/feature_command.md Outdated Show resolved Hide resolved
docs/ja/feature_command.md Outdated Show resolved Hide resolved
@mtei mtei requested a review from a team April 18, 2020 15:08
@mtei
Copy link
Contributor

mtei commented Apr 18, 2020

I think this is ready to merge.

@mtei mtei merged commit 0d658e0 into qmk:master Apr 20, 2020
@mtei
Copy link
Contributor

mtei commented Apr 20, 2020

Thanks !

kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
* add feature_command.md translation

* update based on comment
rockwarrior added a commit to rockwarrior/qmk_firmware that referenced this pull request Apr 23, 2020
* upstream: (1037 commits)
  [Keyboard] Add wasdat code controller (qmk#8858)
  fix sample code indent in feature_encoders.md (qmk#8883)
  [Keymap] Clean up my ergo keymaps and userspace (qmk#8857)
  idb 60 Bugfixes / Preparations for Open Source Hardware (qmk#8866)
  Rebound: add rev2 and thus rev1 as well (qmk#8630)
  Update vitamins included default keymap, enable NKRO, rev2 rgbsplit (qmk#8871)
  Update to xealousbrown. (qmk#8215)
  [Keyboard] DMQ Design SPIN (qmk#8820)
  Wheatfield Blocked65: Update RGBLED num (qmk#8725)
  Add VIA support to ID80 (qmk#8791)
  CFTKB Mysterium & Discipad VIA support (qmk#8794)
  Clean up ATSAM ifdefs (qmk#8808)
  [Docs] Japanese translation of docs/feature_encoders.md (qmk#8843)
  Add naked60 layout, clean up my userspace files and rules.mk. (qmk#8848)
  Fixing DecadePad Numlock LED Bug (qmk#8831)
  [Docs] Japanese translation of docs/feature_command.md (qmk#8672)
  Add support for YMD75 rev 2 (qmk#8853)
  Remove no-longer-necessary LTO checks from keyboards' config.h files (qmk#8773)
  Fix ta-65 tsangan layouts (qmk#8855)
  Fix Plain60 layout (qmk#8854)
  ...
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request May 3, 2020
* add feature_command.md translation

* update based on comment
@umi-umi umi-umi deleted the feature_command.md-japanese-transration branch May 3, 2020 03:35
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
* add feature_command.md translation

* update based on comment
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
* add feature_command.md translation

* update based on comment
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
* add feature_command.md translation

* update based on comment
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* add feature_command.md translation

* update based on comment
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
* add feature_command.md translation

* update based on comment
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* add feature_command.md translation

* update based on comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants