Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wheatfield Blocked65: Update RGBLED num #8725

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Wheatfield Blocked65: Update RGBLED num #8725

merged 1 commit into from
Apr 21, 2020

Conversation

TerryMathews
Copy link
Contributor

@TerryMathews TerryMathews commented Apr 7, 2020 •
edited
Loading

Evidently there is a polycarb variant with underglow LEDs. This change should support that without negatively impacting aluminum case variant which only has 2 RGB LEDs on top.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@TerryMathews
Wheatfield Blocked65: Update RGBLED num
80ceec3 
Evidently there is a polycarb variant with underglow LEDs. This change should support that without negatively impacting aluminum case variant which only has 2 RGB LEDs on top.
@TerryMathews
Copy link
Contributor Author

@zvecr Is there something wrong with this PR? It hasn't been labeled yet.

It's one simple change - just so RGB will work correctly on the PC variant when Configurator is used to generate firmware.

@zvecr
Copy link
Member

zvecr commented Apr 12, 2020

Busy times for us at the moment, so some PRs slip through the cracks.

"simple" maybe, the change has some subtle issues similar ish to #8629. Animations such as the knight rider one will now render 12 of those off the end of a 2 led setup you mention. Is it the same PCB in both cases?

@zvecr zvecr added the keyboard label Apr 12, 2020
@zvecr zvecr requested a review from a team April 12, 2020 00:12
@TerryMathews
Copy link
Contributor Author

Yes, it's the same PCB. The aluminum case kit comes with a PCB that has the pads for the RGB LEDs but they're unpopulated.

I suppose I could split it into different subprojects - blocked65/alu and blocked65/pc. Thoughts?

@noroadsleft
Copy link
Member

Yes, it's the same PCB. The aluminum case kit comes with a PCB that has the pads for the RGB LEDs but they're unpopulated.

I suppose I could split it into different subprojects - blocked65/alu and blocked65/pc. Thoughts?

Generally I would say "same PCB, same project," but what happens when you run RGBLED_NUM 14 on the aluminum kit's PCB?

@TerryMathews
Copy link
Contributor Author

TerryMathews commented Apr 12, 2020 •
edited
Loading

It's exactly as zvecr describes. Anything that repeats on a timer is thrown off because it's iterating through an additional 12 variations that don't exist. I guess I had assumed that most users with the two-LED variant would be using solid color designs and matching it to their keycaps or cases or whatever. I didn't really think about running a a pattern on a 2 LED bank.

To be clear, it works fine. It just has a long cycle time.

@TerryMathews
Copy link
Contributor Author

@drashna Can we move this along and get it merged?

@noroadsleft noroadsleft merged commit 357c600 into qmk:master Apr 21, 2020
@noroadsleft
Copy link
Member

Thanks!

kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@TerryMathews @kujawakk
Wheatfield Blocked65: Update RGBLED num (qmk#8725)
03c0c27 
Evidently there is a polycarb variant with underglow LEDs. This change should support that without negatively impacting aluminum case variant which only has 2 RGB LEDs on top.
rockwarrior added a commit to rockwarrior/qmk_firmware that referenced this pull request Apr 23, 2020
@rockwarrior
Merge branch 'upstream'
dff8c1b 
* upstream: (1037 commits)
  [Keyboard] Add wasdat code controller (qmk#8858)
  fix sample code indent in feature_encoders.md (qmk#8883)
  [Keymap] Clean up my ergo keymaps and userspace (qmk#8857)
  idb 60 Bugfixes / Preparations for Open Source Hardware (qmk#8866)
  Rebound: add rev2 and thus rev1 as well (qmk#8630)
  Update vitamins included default keymap, enable NKRO, rev2 rgbsplit (qmk#8871)
  Update to xealousbrown. (qmk#8215)
  [Keyboard] DMQ Design SPIN (qmk#8820)
  Wheatfield Blocked65: Update RGBLED num (qmk#8725)
  Add VIA support to ID80 (qmk#8791)
  CFTKB Mysterium & Discipad VIA support (qmk#8794)
  Clean up ATSAM ifdefs (qmk#8808)
  [Docs] Japanese translation of docs/feature_encoders.md (qmk#8843)
  Add naked60 layout, clean up my userspace files and rules.mk. (qmk#8848)
  Fixing DecadePad Numlock LED Bug (qmk#8831)
  [Docs] Japanese translation of docs/feature_command.md (qmk#8672)
  Add support for YMD75 rev 2 (qmk#8853)
  Remove no-longer-necessary LTO checks from keyboards' config.h files (qmk#8773)
  Fix ta-65 tsangan layouts (qmk#8855)
  Fix Plain60 layout (qmk#8854)
  ...
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request May 3, 2020
@TerryMathews @violet-fish
Wheatfield Blocked65: Update RGBLED num (qmk#8725)
bc11c54 
Evidently there is a polycarb variant with underglow LEDs. This change should support that without negatively impacting aluminum case variant which only has 2 RGB LEDs on top.
@TerryMathews TerryMathews deleted the patch-1 branch May 7, 2020 15:28
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@TerryMathews @lorenzoernesto
Wheatfield Blocked65: Update RGBLED num (qmk#8725)
f0c02b3 
Evidently there is a polycarb variant with underglow LEDs. This change should support that without negatively impacting aluminum case variant which only has 2 RGB LEDs on top.
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@TerryMathews @sowbug
Wheatfield Blocked65: Update RGBLED num (qmk#8725)
7975890 
Evidently there is a polycarb variant with underglow LEDs. This change should support that without negatively impacting aluminum case variant which only has 2 RGB LEDs on top.
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@TerryMathews @turky
Wheatfield Blocked65: Update RGBLED num (qmk#8725)
eecfdc4 
Evidently there is a polycarb variant with underglow LEDs. This change should support that without negatively impacting aluminum case variant which only has 2 RGB LEDs on top.
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@TerryMathews @jakobaa
Wheatfield Blocked65: Update RGBLED num (qmk#8725)
d887cd3 
Evidently there is a polycarb variant with underglow LEDs. This change should support that without negatively impacting aluminum case variant which only has 2 RGB LEDs on top.
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@TerryMathews @sjmacneil
Wheatfield Blocked65: Update RGBLED num (qmk#8725)
eade2a3 
Evidently there is a polycarb variant with underglow LEDs. This change should support that without negatively impacting aluminum case variant which only has 2 RGB LEDs on top.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TerryMathews @zvecr @noroadsleft @drashna