Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vitamins included default keymap, enable NKRO, rev2 rgbsplit #8871

Merged
merged 2 commits into from
Apr 21, 2020
Merged

Update vitamins included default keymap, enable NKRO, rev2 rgbsplit #8871

merged 2 commits into from
Apr 21, 2020

Conversation

Duckle29
Copy link
Contributor

Description

When I initially made the keymaps for vitamins_included, I was barely familiar with qmk and the conventions. On top of that, things have also changed a bit, and features like RGBSPLIT are available (Or I entirely missed them when first making the keymap, also very posible :) )

I've:

  • Enabled NKRO and added NKRO toggle keycodes to either half for legacy bios support
  • Removed AG_SWAP and AG_NORM as the board doesn't use bootmagic
  • Moved the layout keys to imo easier to remember locations
  • Switched layer names to use an enum
  • Enabled RBGLED_SPLIT for the rev2

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Duckle29 added 2 commits April 21, 2020 13:32
@Duckle29
Update default vitamins_included keymap
5a8392d 
* Turned on NKRO support
* Added NKRO toggle key to keymap
* Cleaned up key map to be more up to date with current standards
@Duckle29
configured RGBLED_SPLIT
7a2580e
@Duckle29 Duckle29 mentioned this pull request Apr 21, 2020
Merged
13 tasks
@zvecr zvecr merged commit f788965 into qmk:master Apr 21, 2020
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@Duckle29 @kujawakk
Update vitamins included default keymap, enable NKRO, rev2 rgbsplit (q…
30fb582 
…mk#8871)

* Update default vitamins_included keymap

* Turned on NKRO support
* Added NKRO toggle key to keymap
* Cleaned up key map to be more up to date with current standards

* configured RGBLED_SPLIT
rockwarrior added a commit to rockwarrior/qmk_firmware that referenced this pull request Apr 23, 2020
@rockwarrior
Merge branch 'upstream'
dff8c1b 
* upstream: (1037 commits)
  [Keyboard] Add wasdat code controller (qmk#8858)
  fix sample code indent in feature_encoders.md (qmk#8883)
  [Keymap] Clean up my ergo keymaps and userspace (qmk#8857)
  idb 60 Bugfixes / Preparations for Open Source Hardware (qmk#8866)
  Rebound: add rev2 and thus rev1 as well (qmk#8630)
  Update vitamins included default keymap, enable NKRO, rev2 rgbsplit (qmk#8871)
  Update to xealousbrown. (qmk#8215)
  [Keyboard] DMQ Design SPIN (qmk#8820)
  Wheatfield Blocked65: Update RGBLED num (qmk#8725)
  Add VIA support to ID80 (qmk#8791)
  CFTKB Mysterium & Discipad VIA support (qmk#8794)
  Clean up ATSAM ifdefs (qmk#8808)
  [Docs] Japanese translation of docs/feature_encoders.md (qmk#8843)
  Add naked60 layout, clean up my userspace files and rules.mk. (qmk#8848)
  Fixing DecadePad Numlock LED Bug (qmk#8831)
  [Docs] Japanese translation of docs/feature_command.md (qmk#8672)
  Add support for YMD75 rev 2 (qmk#8853)
  Remove no-longer-necessary LTO checks from keyboards' config.h files (qmk#8773)
  Fix ta-65 tsangan layouts (qmk#8855)
  Fix Plain60 layout (qmk#8854)
  ...
violet-fish pushed a commit to violet-fish/qmk_firmware that referenced this pull request May 3, 2020
@Duckle29 @violet-fish
Update vitamins included default keymap, enable NKRO, rev2 rgbsplit (q…
3439745 
…mk#8871)

* Update default vitamins_included keymap

* Turned on NKRO support
* Added NKRO toggle key to keymap
* Cleaned up key map to be more up to date with current standards

* configured RGBLED_SPLIT
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@Duckle29 @lorenzoernesto
Update vitamins included default keymap, enable NKRO, rev2 rgbsplit (q…
72cad74 
…mk#8871)

* Update default vitamins_included keymap

* Turned on NKRO support
* Added NKRO toggle key to keymap
* Cleaned up key map to be more up to date with current standards

* configured RGBLED_SPLIT
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@Duckle29 @sowbug
Update vitamins included default keymap, enable NKRO, rev2 rgbsplit (q…
584cc26 
…mk#8871)

* Update default vitamins_included keymap

* Turned on NKRO support
* Added NKRO toggle key to keymap
* Cleaned up key map to be more up to date with current standards

* configured RGBLED_SPLIT
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@Duckle29 @turky
Update vitamins included default keymap, enable NKRO, rev2 rgbsplit (q…
8cedb47 
…mk#8871)

* Update default vitamins_included keymap

* Turned on NKRO support
* Added NKRO toggle key to keymap
* Cleaned up key map to be more up to date with current standards

* configured RGBLED_SPLIT
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@Duckle29 @jakobaa
Update vitamins included default keymap, enable NKRO, rev2 rgbsplit (q…
f63ccc7 
…mk#8871)

* Update default vitamins_included keymap

* Turned on NKRO support
* Added NKRO toggle key to keymap
* Cleaned up key map to be more up to date with current standards

* configured RGBLED_SPLIT
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@Duckle29 @sjmacneil
Update vitamins included default keymap, enable NKRO, rev2 rgbsplit (q…
73360b4 
…mk#8871)

* Update default vitamins_included keymap

* Turned on NKRO support
* Added NKRO toggle key to keymap
* Cleaned up key map to be more up to date with current standards

* configured RGBLED_SPLIT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Duckle29 @zvecr