Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recent clang-format breaking quantum.c #8282

Merged
merged 1 commit into from
Mar 1, 2020
Merged

Fix recent clang-format breaking quantum.c #8282

merged 1 commit into from
Mar 1, 2020

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 1, 2020 •
edited
Loading

Description

  • doesnt happen with clang-format-8
    • not easy to get into the environment
  • doesnt happen on 7 if i remove a comment...
    • fragile so something to keep an eye on
    • maybe need to change the process to catch this sort of error in the future

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested review from fauxpark and a team March 1, 2020 17:10
fauxpark
fauxpark approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure the comment is wrong anyway.

@fauxpark fauxpark mentioned this pull request Mar 1, 2020
Closed
13 tasks
@gwjo gwjo mentioned this pull request Mar 1, 2020
Closed
13 tasks
@zvecr zvecr merged commit 629950e into qmk:master Mar 1, 2020
rhruiz pushed a commit to rhruiz/qmk_firmware that referenced this pull request Mar 1, 2020
@zvecr @rhruiz
Fix recent clang-format breaking quantum.c (qmk#8282)
6d417ba
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Mar 3, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
3bd02bc 
* 'master' of https://github.com/qmk/qmk_firmware: (37 commits)
  Update Hungarian keymap and add sendstring LUT (qmk#8220)
  Remove "ugly hack in usb_main.c" comments (qmk#8296)
  Update encoder functions for Iris VIA keymap (qmk#8295)
  Reduce PROGMEM usage for sendstring LUT (qmk#8109)
  [Docs] Update ISP Flashing guide (qmk#8149)
  Rewrite the Bathroom Epiphanies Frosty Flake matrix and LED handling (qmk#8243)
  Add onekey keymap for testing reset to bootloader. (qmk#8288)
  Get the direction right on the S75 encoder (qmk#8287)
  Prune out pure software pwm && custom driver && remove wrapping BACKLIGHT_PIN (qmk#8041)
  Make a fix to savage65 and tmov2 for via (qmk#8286)
  format code according to conventions [skip ci]
  Short term fix for conflicting types for 'tfp_printf' (qmk#8157)
  Fix recent clang-format breaking quantum.c (qmk#8282)
  format code according to conventions [skip ci]
  Remove duplicate BRTG case (qmk#8277)
  Clean up includes for glcdfont headers (qmk#7745)
  Fix the Breaking Changes doc again
  [Docs] translated 'feature_tap_dance.md' to japanese. (qmk#8137)
  PWM DMA based RGB Underglow for STM32 (qmk#7928)
  Add VIA support to Prime_M. Clean up all files (qmk#8247)
  ...
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Mar 5, 2020
@zvecr @HokieGeek
Fix recent clang-format breaking quantum.c (qmk#8282)
e6ba83f
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@zvecr @c0psrul3
Fix recent clang-format breaking quantum.c (qmk#8282)
45fe3ec
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
@zvecr @sowbug
Fix recent clang-format breaking quantum.c (qmk#8282)
562639e
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@zvecr @kujawakk
Fix recent clang-format breaking quantum.c (qmk#8282)
42b76ac
@zvecr zvecr deleted the feature/fix_format branch April 28, 2020 01:13
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 24, 2020
@zvecr @drashna
Fix recent clang-format breaking quantum.c (qmk#8282)
5c047ed
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 24, 2020
@zvecr @drashna
Fix recent clang-format breaking quantum.c (qmk#8282)
e81a537
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jun 12, 2020
@zvecr @fdidron
Fix recent clang-format breaking quantum.c (qmk#8282)
ae484e3
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@zvecr @jakeisnt
Fix recent clang-format breaking quantum.c (qmk#8282)
03a90bf
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Fix recent clang-format breaking quantum.c (qmk#8282)
9a1c560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skullydazed skullydazed skullydazed approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @fauxpark @skullydazed