Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up includes for glcdfont headers #7745

Merged
merged 3 commits into from
Mar 1, 2020
Merged

Clean up includes for glcdfont headers #7745

merged 3 commits into from
Mar 1, 2020

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Dec 31, 2019 •
edited
Loading

Description

tmk_core/progmem.h does much the same as this preprocessor code. I don't see where ESP8266 is defined, or supported, so I'm assuming this is just copypasta and we can ignore it.

Tagging the following for approval, as this touches your keymaps (but should not change anything behaviourally):
@drashna ✅
@kidBrazil ✅
@MakotoKurauchi ✅
@rpbaptist ✅
@soundmonster ✅
@tominabox1 ✅

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team December 31, 2019 07:19
@fauxpark
Copy link
Member Author

Also tagging @tominabox1

@rpbaptist
Copy link
Contributor

@fauxpark Everything seems okay here on my keymap with this change. 👍

tominabox1
tominabox1 previously approved these changes Dec 31, 2019
View reviewed changes
Copy link
Contributor

@tominabox1 tominabox1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks for the heads up.

drashna
drashna previously approved these changes Jan 2, 2020
View reviewed changes
@drashna drashna requested a review from a team January 2, 2020 20:59
kidBrazil
kidBrazil previously approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@kidBrazil kidBrazil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Curry added a commit to Curry/qmk_firmware that referenced this pull request Jan 9, 2020
@Curry
glcdfont changes from qmk#7745
6cef921
drashna pushed a commit that referenced this pull request Jan 9, 2020
@Curry @drashna
[Keymap] Userspace refactor, adding leader key functionality (#7790)
caa70df 
* Userspace refactor

* Fixed missed ifdef

* tapcode16, adjust layout

* glcdfont changes from #7745

* Modify Keymaps, add workman

* RGB & OLED update
@fauxpark fauxpark mentioned this pull request Jan 14, 2020
Merged
13 tasks
@fauxpark
Copy link
Member Author

@MakotoKurauchi and @soundmonster, would you mind adding your approvals to this PR? Thanks :)

ridingqwerty
ridingqwerty previously approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending sign off from the remaining users.

MakotoKurauchi
MakotoKurauchi previously approved these changes Feb 13, 2020
View reviewed changes
@fauxpark fauxpark mentioned this pull request Feb 20, 2020
Merged
4 tasks
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@Curry @HokieGeek
[Keymap] Userspace refactor, adding leader key functionality (qmk#7790)
8b60897 
* Userspace refactor

* Fixed missed ifdef

* tapcode16, adjust layout

* glcdfont changes from qmk#7745

* Modify Keymaps, add workman

* RGB & OLED update
soundmonster
soundmonster previously approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@soundmonster soundmonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️

@fauxpark fauxpark dismissed stale reviews from drashna and tominabox1 via b8c29d3 February 28, 2020 17:40
@fauxpark fauxpark removed the on hold label Feb 28, 2020
@drashna drashna requested a review from a team March 1, 2020 01:25
@fauxpark fauxpark merged commit c9e3fa6 into qmk:master Mar 1, 2020
@fauxpark fauxpark deleted the glcdfont-includes branch March 1, 2020 06:56
cmaier pushed a commit to cmaier/qmk_firmware that referenced this pull request Mar 1, 2020
@fauxpark @cmaier
Clean up includes for glcdfont headers (qmk#7745)
77eb9d6 
* Clean up includes for glcdfont headers

* Remove pragma once, most of these are not headers

* Missed these
rhruiz pushed a commit to rhruiz/qmk_firmware that referenced this pull request Mar 1, 2020
@fauxpark @rhruiz
Clean up includes for glcdfont headers (qmk#7745)
7e390b5 
* Clean up includes for glcdfont headers

* Remove pragma once, most of these are not headers

* Missed these
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Mar 3, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
3bd02bc 
* 'master' of https://github.com/qmk/qmk_firmware: (37 commits)
  Update Hungarian keymap and add sendstring LUT (qmk#8220)
  Remove "ugly hack in usb_main.c" comments (qmk#8296)
  Update encoder functions for Iris VIA keymap (qmk#8295)
  Reduce PROGMEM usage for sendstring LUT (qmk#8109)
  [Docs] Update ISP Flashing guide (qmk#8149)
  Rewrite the Bathroom Epiphanies Frosty Flake matrix and LED handling (qmk#8243)
  Add onekey keymap for testing reset to bootloader. (qmk#8288)
  Get the direction right on the S75 encoder (qmk#8287)
  Prune out pure software pwm && custom driver && remove wrapping BACKLIGHT_PIN (qmk#8041)
  Make a fix to savage65 and tmov2 for via (qmk#8286)
  format code according to conventions [skip ci]
  Short term fix for conflicting types for 'tfp_printf' (qmk#8157)
  Fix recent clang-format breaking quantum.c (qmk#8282)
  format code according to conventions [skip ci]
  Remove duplicate BRTG case (qmk#8277)
  Clean up includes for glcdfont headers (qmk#7745)
  Fix the Breaking Changes doc again
  [Docs] translated 'feature_tap_dance.md' to japanese. (qmk#8137)
  PWM DMA based RGB Underglow for STM32 (qmk#7928)
  Add VIA support to Prime_M. Clean up all files (qmk#8247)
  ...
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Mar 5, 2020
@fauxpark @HokieGeek
Clean up includes for glcdfont headers (qmk#7745)
854da70 
* Clean up includes for glcdfont headers

* Remove pragma once, most of these are not headers

* Missed these
@zvecr zvecr mentioned this pull request Mar 17, 2020
Merged
13 tasks
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@fauxpark @c0psrul3
Clean up includes for glcdfont headers (qmk#7745)
042c6a1 
* Clean up includes for glcdfont headers

* Remove pragma once, most of these are not headers

* Missed these
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
@fauxpark @sowbug
Clean up includes for glcdfont headers (qmk#7745)
f298171 
* Clean up includes for glcdfont headers

* Remove pragma once, most of these are not headers

* Missed these
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@Curry @kujawakk
[Keymap] Userspace refactor, adding leader key functionality (qmk#7790)
08ac8bc 
* Userspace refactor

* Fixed missed ifdef

* tapcode16, adjust layout

* glcdfont changes from qmk#7745

* Modify Keymaps, add workman

* RGB & OLED update
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@fauxpark @kujawakk
Clean up includes for glcdfont headers (qmk#7745)
5112eda 
* Clean up includes for glcdfont headers

* Remove pragma once, most of these are not headers

* Missed these
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 24, 2020
@fauxpark @drashna
Clean up includes for glcdfont headers (qmk#7745)
6a14434 
* Clean up includes for glcdfont headers

* Remove pragma once, most of these are not headers

* Missed these
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request May 24, 2020
@fauxpark @drashna
Clean up includes for glcdfont headers (qmk#7745)
ebb57c5 
* Clean up includes for glcdfont headers

* Remove pragma once, most of these are not headers

* Missed these
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jun 12, 2020
@fauxpark @fdidron
Clean up includes for glcdfont headers (qmk#7745)
6f63eff 
* Clean up includes for glcdfont headers

* Remove pragma once, most of these are not headers

* Missed these
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@fauxpark @jakeisnt
Clean up includes for glcdfont headers (qmk#7745)
2b84bdc 
* Clean up includes for glcdfont headers

* Remove pragma once, most of these are not headers

* Missed these
@fauxpark fauxpark mentioned this pull request Dec 9, 2020
Merged
14 tasks
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@Curry @drashna
[Keymap] Userspace refactor, adding leader key functionality (qmk#7790)
2989c75 
* Userspace refactor

* Fixed missed ifdef

* tapcode16, adjust layout

* glcdfont changes from qmk#7745

* Modify Keymaps, add workman

* RGB & OLED update
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark
Clean up includes for glcdfont headers (qmk#7745)
9669a32 
* Clean up includes for glcdfont headers

* Remove pragma once, most of these are not headers

* Missed these
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tominabox1 tominabox1 tominabox1 left review comments

@ridingqwerty ridingqwerty ridingqwerty left review comments

@kidBrazil kidBrazil kidBrazil left review comments

@MakotoKurauchi MakotoKurauchi MakotoKurauchi left review comments

@soundmonster soundmonster soundmonster left review comments

Assignees
No one assigned
Labels
core keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@fauxpark @rpbaptist @soundmonster @drashna @MakotoKurauchi @kidBrazil @ridingqwerty @tominabox1