Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VIA support to Prime_M. Clean up all files #8247

Merged
merged 30 commits into from
Mar 1, 2020
Merged

Add VIA support to Prime_M. Clean up all files #8247

merged 30 commits into from
Mar 1, 2020

Conversation

holtenc
Copy link
Contributor

@holtenc holtenc commented Feb 25, 2020

This PR adds support for VIA. In addition I went through and cleaned things up to be in line with requested changes on my recent merged PRs.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

holtenc and others added 26 commits February 23, 2020 12:07
@holtenc
Add VIA support for Prime_L
f5fc330
@holtenc @drashna
Update keyboards/primekb/prime_l/v1/config.h
dfd1369 
Co-Authored-By: Drashna Jaelre <[email protected]>
@holtenc
Add prime_exl_plus keyboard
11f9df2
@holtenc
Merge branch 'master' of https://github.com/holtenc/qmk_firmware
a575be2
@holtenc
Temporary removal of prime_exl_plus
42f60e7
@holtenc
Add Prime_EXL Plus, including VIA support
498a6c2
@holtenc
Merge branch 'master' of https://github.com/qmk/qmk_firmware
72711de 
sync with upstream master
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/readme.md
eb3c192 
Co-Authored-By: James Young <[email protected]>
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/readme.md
2e2de83 
Co-Authored-By: James Young <[email protected]>
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/readme.md
14aec00 
Co-Authored-By: James Young <[email protected]>
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/rules.mk
e369698 
Co-Authored-By: James Young <[email protected]>
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/info.json
4f7df3f 
Co-Authored-By: James Young <[email protected]>
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/info.json
f1f2d1c 
Co-Authored-By: James Young <[email protected]>
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/info.json
56e9c99 
Co-Authored-By: James Young <[email protected]>
@holtenc
Update keymap.c
97a8556
@holtenc
Merge branch 'master' of https://github.com/holtenc/qmk_firmware
1de6a36
@holtenc
correct spacing of keymaps and layout macro. move indicator logic fro…
8dc7605 
…m user space to keyboard space
@holtenc
further corrections to keymaps and layout macro.
f69069f
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c
e853390 
Co-Authored-By: James Young <[email protected]>
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c
6bc9866 
Co-Authored-By: James Young <[email protected]>
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c
93ecdbb 
Co-Authored-By: James Young <[email protected]>
@holtenc @noroadsleft
Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c
3ecf2a0 
Co-Authored-By: James Young <[email protected]>
@holtenc
Update prime_exl_plus.c
f1d88fd
@holtenc
small edit to prime_exl_plus.c
ec9201c
@holtenc
Add via support to Prime_M and clean things up
97436d1
@holtenc
Merge branch 'master' of https://github.com/qmk/qmk_firmware
81dc1db 
sync with upstream
@holtenc
Copy link
Contributor Author

holtenc commented Feb 25, 2020 •
edited
Loading

This should be my last PR for a good long while. Thanks for your patience guys.

@zvecr zvecr requested a review from a team February 26, 2020 16:11
fauxpark
fauxpark requested changes Feb 26, 2020
View reviewed changes
keyboards/primekb/prime_m/rules.mk Outdated Show resolved Hide resolved
keyboards/primekb/prime_m/rules.mk Outdated Show resolved Hide resolved
@holtenc holtenc requested a review from fauxpark February 26, 2020 18:17
fauxpark
fauxpark previously approved these changes Feb 27, 2020
View reviewed changes
noroadsleft
noroadsleft requested changes Feb 29, 2020
View reviewed changes
keyboards/primekb/prime_m/readme.md Outdated Show resolved Hide resolved
keyboards/primekb/prime_m/readme.md Outdated Show resolved Hide resolved
keyboards/primekb/prime_m/config.h Outdated Show resolved Hide resolved
@holtenc holtenc requested a review from noroadsleft February 29, 2020 15:58
@drashna drashna requested a review from a team March 1, 2020 00:43
@noroadsleft noroadsleft merged commit bb47236 into qmk:master Mar 1, 2020
@noroadsleft
Copy link
Member

Thanks!

cmaier pushed a commit to cmaier/qmk_firmware that referenced this pull request Mar 1, 2020
@holtenc @cmaier
Add VIA support to Prime_M. Clean up all files (qmk#8247)
82f4ab7 
* Add VIA support for Prime_L

* Update keyboards/primekb/prime_l/v1/config.h

* Add prime_exl_plus keyboard

* Temporary removal of prime_exl_plus

* Add Prime_EXL Plus, including VIA support

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/rules.mk

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keymap.c

* correct spacing of keymaps and layout macro. move indicator logic from user space to keyboard space

* further corrections to keymaps and layout macro.

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update prime_exl_plus.c

* small edit to prime_exl_plus.c

* Add via support to Prime_M and clean things up

* Update rules.mk

* Update keyboards/primekb/prime_m/readme.md

* Update keyboards/primekb/prime_m/readme.md

* Update keyboards/primekb/prime_m/config.h
rhruiz pushed a commit to rhruiz/qmk_firmware that referenced this pull request Mar 1, 2020
@holtenc @rhruiz
Add VIA support to Prime_M. Clean up all files (qmk#8247)
74b42d1 
* Add VIA support for Prime_L

* Update keyboards/primekb/prime_l/v1/config.h

* Add prime_exl_plus keyboard

* Temporary removal of prime_exl_plus

* Add Prime_EXL Plus, including VIA support

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/rules.mk

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keymap.c

* correct spacing of keymaps and layout macro. move indicator logic from user space to keyboard space

* further corrections to keymaps and layout macro.

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update prime_exl_plus.c

* small edit to prime_exl_plus.c

* Add via support to Prime_M and clean things up

* Update rules.mk

* Update keyboards/primekb/prime_m/readme.md

* Update keyboards/primekb/prime_m/readme.md

* Update keyboards/primekb/prime_m/config.h
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Mar 3, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
3bd02bc 
* 'master' of https://github.com/qmk/qmk_firmware: (37 commits)
  Update Hungarian keymap and add sendstring LUT (qmk#8220)
  Remove "ugly hack in usb_main.c" comments (qmk#8296)
  Update encoder functions for Iris VIA keymap (qmk#8295)
  Reduce PROGMEM usage for sendstring LUT (qmk#8109)
  [Docs] Update ISP Flashing guide (qmk#8149)
  Rewrite the Bathroom Epiphanies Frosty Flake matrix and LED handling (qmk#8243)
  Add onekey keymap for testing reset to bootloader. (qmk#8288)
  Get the direction right on the S75 encoder (qmk#8287)
  Prune out pure software pwm && custom driver && remove wrapping BACKLIGHT_PIN (qmk#8041)
  Make a fix to savage65 and tmov2 for via (qmk#8286)
  format code according to conventions [skip ci]
  Short term fix for conflicting types for 'tfp_printf' (qmk#8157)
  Fix recent clang-format breaking quantum.c (qmk#8282)
  format code according to conventions [skip ci]
  Remove duplicate BRTG case (qmk#8277)
  Clean up includes for glcdfont headers (qmk#7745)
  Fix the Breaking Changes doc again
  [Docs] translated 'feature_tap_dance.md' to japanese. (qmk#8137)
  PWM DMA based RGB Underglow for STM32 (qmk#7928)
  Add VIA support to Prime_M. Clean up all files (qmk#8247)
  ...
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Mar 5, 2020
@holtenc @HokieGeek
Add VIA support to Prime_M. Clean up all files (qmk#8247)
260012e 
* Add VIA support for Prime_L

* Update keyboards/primekb/prime_l/v1/config.h

* Add prime_exl_plus keyboard

* Temporary removal of prime_exl_plus

* Add Prime_EXL Plus, including VIA support

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/rules.mk

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keymap.c

* correct spacing of keymaps and layout macro. move indicator logic from user space to keyboard space

* further corrections to keymaps and layout macro.

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update prime_exl_plus.c

* small edit to prime_exl_plus.c

* Add via support to Prime_M and clean things up

* Update rules.mk

* Update keyboards/primekb/prime_m/readme.md

* Update keyboards/primekb/prime_m/readme.md

* Update keyboards/primekb/prime_m/config.h
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@holtenc @c0psrul3
Add VIA support to Prime_M. Clean up all files (qmk#8247)
a21f765 
* Add VIA support for Prime_L

* Update keyboards/primekb/prime_l/v1/config.h

* Add prime_exl_plus keyboard

* Temporary removal of prime_exl_plus

* Add Prime_EXL Plus, including VIA support

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/rules.mk

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keymap.c

* correct spacing of keymaps and layout macro. move indicator logic from user space to keyboard space

* further corrections to keymaps and layout macro.

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update prime_exl_plus.c

* small edit to prime_exl_plus.c

* Add via support to Prime_M and clean things up

* Update rules.mk

* Update keyboards/primekb/prime_m/readme.md

* Update keyboards/primekb/prime_m/readme.md

* Update keyboards/primekb/prime_m/config.h
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
@holtenc @sowbug
Add VIA support to Prime_M. Clean up all files (qmk#8247)
c29e43b 
* Add VIA support for Prime_L

* Update keyboards/primekb/prime_l/v1/config.h

* Add prime_exl_plus keyboard

* Temporary removal of prime_exl_plus

* Add Prime_EXL Plus, including VIA support

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/rules.mk

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keymap.c

* correct spacing of keymaps and layout macro. move indicator logic from user space to keyboard space

* further corrections to keymaps and layout macro.

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update prime_exl_plus.c

* small edit to prime_exl_plus.c

* Add via support to Prime_M and clean things up

* Update rules.mk

* Update keyboards/primekb/prime_m/readme.md

* Update keyboards/primekb/prime_m/readme.md

* Update keyboards/primekb/prime_m/config.h
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@holtenc @kujawakk
Add VIA support to Prime_M. Clean up all files (qmk#8247)
f97a669 
* Add VIA support for Prime_L

* Update keyboards/primekb/prime_l/v1/config.h

* Add prime_exl_plus keyboard

* Temporary removal of prime_exl_plus

* Add Prime_EXL Plus, including VIA support

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/rules.mk

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keymap.c

* correct spacing of keymaps and layout macro. move indicator logic from user space to keyboard space

* further corrections to keymaps and layout macro.

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update prime_exl_plus.c

* small edit to prime_exl_plus.c

* Add via support to Prime_M and clean things up

* Update rules.mk

* Update keyboards/primekb/prime_m/readme.md

* Update keyboards/primekb/prime_m/readme.md

* Update keyboards/primekb/prime_m/config.h
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@holtenc @jakeisnt
Add VIA support to Prime_M. Clean up all files (qmk#8247)
00a48c0 
* Add VIA support for Prime_L

* Update keyboards/primekb/prime_l/v1/config.h

* Add prime_exl_plus keyboard

* Temporary removal of prime_exl_plus

* Add Prime_EXL Plus, including VIA support

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/readme.md

* Update keyboards/handwired/prime_exl_plus/rules.mk

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keyboards/handwired/prime_exl_plus/info.json

* Update keymap.c

* correct spacing of keymaps and layout macro. move indicator logic from user space to keyboard space

* further corrections to keymaps and layout macro.

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update keyboards/handwired/prime_exl_plus/prime_exl_plus.c

* Update prime_exl_plus.c

* small edit to prime_exl_plus.c

* Add via support to Prime_M and clean things up

* Update rules.mk

* Update keyboards/primekb/prime_m/readme.md

* Update keyboards/primekb/prime_m/readme.md

* Update keyboards/primekb/prime_m/config.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@holtenc @noroadsleft @drashna @fauxpark @zvecr