PWM DMA based RGB Underglow for STM32 #7928

zvecr · 2020-01-18T16:51:22Z

Description

Based off https://github.com/joewa/WS2812-LED-Driver_ChibiOS, this PR aims to implement ws2812 PWM support within the new ws2812 framework.

	Status
f072	?
f103	✔️
f303	✔️
f401/f411	✔️

Notes

I have added a non documented WS2812_PWM_TARGET_PERIOD option
- the original code seems to use a 10x larger value, but does not work with the testing i've done so far
- if required, board maintainers can use whatever value works for them

Types of Changes

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

tzarc · 2020-01-19T01:12:28Z

Could this leverage something similar to https://github.com/hubmartin/WS2812B_STM32F103/blob/master/src/ws2812b.c to decrease the memory requirements?

zvecr · 2020-01-19T02:44:04Z

Maybe, at the moment I am not too worried about memory usage as its in the same ball park as the SPI driver.

Just trying to remove stuff like keyboards/matrix/noah/ws2812_f4.c from the repo, the Apache stuff in the PR queue, and provide #6516/#6675.

tzarc · 2020-02-02T20:56:03Z

Working with L0xx as well.

drivers/arm/ws2812_pwm.c

PWM DMA based RGB Underglow for STM32

drashna · 2020-02-05T03:30:50Z

__attribute__((weak)) ✅

Want to test it, but .... not up to doing so ATM

drivers/arm/ws2812_pwm.c

Co-Authored-By: Nick Brassel <[email protected]>

tzarc · 2020-03-01T02:02:58Z

Confirmed working with this applied over current post-future master, using L0xx.

* Add pwm ws2812 driver * Add docs for pwm ws2812 driver * Update ws2812_pwm for ChibiOS 19 Co-Authored-By: Nick Brassel <[email protected]> Co-authored-by: Nick Brassel <[email protected]>

yulei · 2020-03-01T14:52:27Z

drivers/arm/ws2812_pwm.c

+#ifndef WS2812_PWM_TARGET_PERIOD
+//#    define WS2812_PWM_TARGET_PERIOD 800000 // Original code is 800k...?
+#    define WS2812_PWM_TARGET_PERIOD 80000  // TODO: work out why 10x less on f303/f4x1


I have used the same codes for the noah keyboard(stm32f11ce based board), and it should use 800K, not sure why it was modified to 80000.

doesnt work with 800K on anything that has been tested so far, which includes some f411 blackpill boards 🤷‍♂️

Maybe the testing system was running with HSI clock(8mHz, not the HSE at 8x9 on f303 or 8x12 on f411)?

yulei · 2020-03-01T15:01:40Z

drivers/arm/ws2812_pwm.c

+/* --- PRIVATE CONSTANTS ---------------------------------------------------- */
+
+#define WS2812_PWM_FREQUENCY (STM32_SYSCLK / 2)                             /**< Clock frequency of PWM, must be valid with respect to system clock! */


The timer's frequency depends on the specific APB1 or APB2's frequency, and which was decided by the APB divider defined on the mcuconf.h. If anyone tuned the value, the PWM frequency will be incorrect, so it better to make this MACRO overridable as the pwm driver and time channel selections.

Feel free to add an incremental PR, but as this has been merged its too late to change it within this PR.

* Add pwm ws2812 driver * Add docs for pwm ws2812 driver * Update ws2812_pwm for ChibiOS 19 Co-Authored-By: Nick Brassel <[email protected]> Co-authored-by: Nick Brassel <[email protected]>

* 'master' of https://github.com/qmk/qmk_firmware: (37 commits) Update Hungarian keymap and add sendstring LUT (qmk#8220) Remove "ugly hack in usb_main.c" comments (qmk#8296) Update encoder functions for Iris VIA keymap (qmk#8295) Reduce PROGMEM usage for sendstring LUT (qmk#8109) [Docs] Update ISP Flashing guide (qmk#8149) Rewrite the Bathroom Epiphanies Frosty Flake matrix and LED handling (qmk#8243) Add onekey keymap for testing reset to bootloader. (qmk#8288) Get the direction right on the S75 encoder (qmk#8287) Prune out pure software pwm && custom driver && remove wrapping BACKLIGHT_PIN (qmk#8041) Make a fix to savage65 and tmov2 for via (qmk#8286) format code according to conventions [skip ci] Short term fix for conflicting types for 'tfp_printf' (qmk#8157) Fix recent clang-format breaking quantum.c (qmk#8282) format code according to conventions [skip ci] Remove duplicate BRTG case (qmk#8277) Clean up includes for glcdfont headers (qmk#7745) Fix the Breaking Changes doc again [Docs] translated 'feature_tap_dance.md' to japanese. (qmk#8137) PWM DMA based RGB Underglow for STM32 (qmk#7928) Add VIA support to Prime_M. Clean up all files (qmk#8247) ...

* Add pwm ws2812 driver * Add docs for pwm ws2812 driver * Update ws2812_pwm for ChibiOS 19 Co-Authored-By: Nick Brassel <[email protected]> Co-authored-by: Nick Brassel <[email protected]>

zvecr added the core label Jan 18, 2020

zvecr requested a review from a team January 18, 2020 16:51

zvecr marked this pull request as ready for review January 20, 2020 02:24

tzarc reviewed Feb 2, 2020

View reviewed changes

drivers/arm/ws2812_pwm.c Outdated Show resolved Hide resolved

tzarc approved these changes Feb 2, 2020

View reviewed changes

tzarc requested a review from a team February 2, 2020 21:23

zvecr added a commit that referenced this pull request Feb 4, 2020

Merge pull request #7928 from zvecr/feature/ws2812_pwm

35c4848

PWM DMA based RGB Underglow for STM32

drashna approved these changes Feb 5, 2020

View reviewed changes

zvecr added 2 commits February 13, 2020 21:23

Add pwm ws2812 driver

00fb068

Add docs for pwm ws2812 driver

79945b6

zvecr force-pushed the feature/ws2812_pwm branch from 3cf5f9f to 79945b6 Compare February 13, 2020 21:23

drashna requested a review from a team February 19, 2020 22:47

tzarc requested changes Mar 1, 2020

View reviewed changes

drivers/arm/ws2812_pwm.c Outdated Show resolved Hide resolved

Update ws2812_pwm for ChibiOS 19

f937de5

Co-Authored-By: Nick Brassel <[email protected]>

tzarc approved these changes Mar 1, 2020

View reviewed changes

tzarc merged commit f74c769 into qmk:master Mar 1, 2020

yulei reviewed Mar 1, 2020

View reviewed changes

zvecr deleted the feature/ws2812_pwm branch April 28, 2020 01:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PWM DMA based RGB Underglow for STM32 #7928

PWM DMA based RGB Underglow for STM32 #7928

zvecr commented Jan 18, 2020 •

edited

Loading

tzarc commented Jan 19, 2020

zvecr commented Jan 19, 2020

tzarc commented Feb 2, 2020

drashna commented Feb 5, 2020

tzarc commented Mar 1, 2020

yulei Mar 1, 2020

zvecr Mar 2, 2020 •

edited

Loading

yulei Mar 2, 2020

yulei Mar 1, 2020

zvecr Mar 2, 2020

		/* --- PRIVATE CONSTANTS ---------------------------------------------------- */

		#define WS2812_PWM_FREQUENCY (STM32_SYSCLK / 2) /*< Clock frequency of PWM, must be valid with respect to system clock! /

PWM DMA based RGB Underglow for STM32 #7928

PWM DMA based RGB Underglow for STM32 #7928

Conversation

zvecr commented Jan 18, 2020 • edited Loading

Description

Notes

Types of Changes

Checklist

tzarc commented Jan 19, 2020

zvecr commented Jan 19, 2020

tzarc commented Feb 2, 2020

drashna commented Feb 5, 2020

tzarc commented Mar 1, 2020

yulei Mar 1, 2020

Choose a reason for hiding this comment

zvecr Mar 2, 2020 • edited Loading

Choose a reason for hiding this comment

yulei Mar 2, 2020

Choose a reason for hiding this comment

yulei Mar 1, 2020

Choose a reason for hiding this comment

zvecr Mar 2, 2020

Choose a reason for hiding this comment

zvecr commented Jan 18, 2020 •

edited

Loading

zvecr Mar 2, 2020 •

edited

Loading