Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2020 February 29 Breaking Changes Update #8064

Closed
wants to merge 16 commits into from
Closed

2020 February 29 Breaking Changes Update #8064

wants to merge 16 commits into from

Conversation

noroadsleft
Copy link
Member

Description

Updates QMK's master branch with the changes from this Breaking Changes cycle.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc
Copy link
Member

tzarc commented Feb 5, 2020 •
edited
Loading

Can we make sure we run a qmk cformat as the last commit on this branch before merge? There are a handful of files in the repo that aren't formatted, and the CI only applies it to merged commits.

@noroadsleft
Copy link
Member Author

I would like to but I can't actually run qmk cformat... my QMK Python toolchain is broken somehow.

@Maxr1998
Copy link
Contributor

Maxr1998 commented Feb 5, 2020

@noroadsleft could you als pull in #7680?

@noroadsleft
Copy link
Member Author

@Maxr1998 We're currently in our testing period, and as such, only accepting bugfixes to the future branch at this time.

Additionally, your PR currently has some merge conflicts, and can't be merged in its current state anyway.

@noroadsleft noroadsleft force-pushed the future branch 2 times, most recently from 8df16a5 to f399226 Compare February 14, 2020 20:14
@noroadsleft noroadsleft mentioned this pull request Feb 22, 2020
Closed
skullydazed and others added 12 commits February 27, 2020 12:05
@skullydazed @noroadsleft
Branch point for 2020 Feb 29 Breaking Change.
8499e8d
@drashna @noroadsleft
Update LUFA submodule (#6825)
5ba4868 
* Update LUFA submodule

* Add changelog
@drashna @noroadsleft
[Core] Feature/encoder flip (#7568)
c586d7d 
* Add `ENCODER_DIRECTION_FLIP` setting

To allow for simple change of direction

In fixing the Split Encoder issues in #7325, the direction was flipped for all encoders.

However, this flip actually corrects the direction to be correct, but this was an unintended change in behavior.
Rather than reverting the dirction (because, now it's actually correctly processing CW vs CCW), lets add an option to flip this, so that users can revert to the older behavior if they want, without having to redefine the pins/pads.

* Revert direction to old behavior

* Make setting easier to read and understand

* Use physically correct direction by default

* Wordsmithing in documentation

* Fix indenting in example

* Add changelog
@fauxpark @noroadsleft
[Core][Backlight] Make hardware PWM respect BACKLIGHT_ON_STATE (#6749)
e073858 
* Branch point for 2019 Nov 30 Breaking Change.

* [Backlight] Make hardware PWM respect BACKLIGHT_ON_STATE

* Add ChangeLog entry

* Branch point for 2019 Nov 30 Breaking Change.

* New breaking changes target date
@fauxpark @noroadsleft
Migrate ACTION_LAYER_TAP_KEY() to LT() (#7277)
9e07b58 
* Branch point for 2019 Nov 30 Breaking Change.

* Migrate `ACTION_LAYER_TAP_KEY()` to `LT()`

* Apply suggestions from code review

* Add ChangeLog entry

* New breaking changes target date
@fauxpark @noroadsleft
[Core] Move backlight keycode handling to process_keycode/ (#7008)
a9dac51 
* Move backlight keycode handling to process_keycode/

* Switch keycode only when pressed

* Remove default case

* Add ChangeLog entry

* New breaking changes target date
@noroadsleft
[Keymap] Refactor Planck keymaps to use Layout Macros (#7172)
21940f1 
* refactor ab keymap

* refactor alexey keymap

* refactor altgr keymap

* refactor andylikescandy keymap

* refactor aviator keymap

* refactor basic keymap

* refactor bone2planck keymap

* refactor brandon keymap

* refactor cbbrowne keymap

* refactor chance keymap

* refactor circuit keymap

* refactor coloneljesus keymap

* refactor corvec keymap

* refactor danielhklein keymap

* refactor dbroqua keymap

* refactor dc keymap

* refactor dcompact keymap

* refactor dlaroe keymap

* refactor dodger keymap

* refactor dr0ck keymap

* refactor dudeofawesome keymap

* refactor emilyh keymap

* refactor espynn keymap

* refactor experimental keymap

* refactor gabriel keymap

* refactor grahampheath keymap

* refactor gunp keymap

* refactor handwired_binaryplease keymap

* refactor hiea keymap

* refactor hieax keymap

* refactor impossible keymap

* refactor jacob keymap

* refactor jeebak keymap

* refactor jeremy-dev keymap

* refactor jhenahan keymap

* refactor jirgn keymap

* refactor johannes keymap

* refactor kelorean keymap

* refactor khord keymap

* refactor kloki keymap

* refactor kmontag42 keymap

* refactor lae3 keymap

* refactor lukas keymap

* refactor luke keymap

* refactor mason keymap

* refactor matrixman keymap

* refactor mjt keymap

* refactor mjtnumsym keymap

* refactor mollat keymap

* refactor myoung34 keymap

* refactor neo2planck keymap

* refactor nico keymap

* refactor not-quite-neo keymap

* refactor originerd keymap

* refactor paget keymap

* refactor palleiko keymap

* refactor pete keymap

* refactor phreed keymap

* refactor piemod keymap

* refactor pok3r keymap

* refactor premek keymap

* refactor pvc keymap

* refactor rai-suta keymap

* refactor rodhaene keymap

* refactor sdothum keymap

* refactor sean keymap

* refactor sgoodwin keymap

* refactor smt keymap

* refactor steno keymap

* refactor tak3over keymap

* refactor tehwalris keymap

* refactor that_canadian keymap

* refactor thermal_printer keymap

* refactor unicode keymap

* refactor yale keymap

* refactor yang keymap

* refactor zach keymap

* refactor zrichard keymap

* refactor angerthosenear keymap

* refactor austin keymap

* refactor charlie keymap

* refactor daniel keymap

* refactor david keymap

* refactor dzobert keymap

* refactor joe keymap

* refactor kyle keymap

* refactor leo keymap

* refactor lucas keymap

* refactor max keymap

* refactor mitch keymap

* refactor samuel keymap

* refactor tong92 keymap

* Add Changelog entry

* move changelog (new breaking changes target date)
@noroadsleft
[Keyboard] GON NerD codebase refactor (#7795)
0f53b96 
* config.h: use #pragma once include guard

* gonnerd.h: use #pragma once include guard

* rules.mk: templating and cleanup

- remove firmware size impact numbers
- add missing rules from AVR template

* gonnerd.h: use four-space indent

* gonnerd.h: change to k<row><column> notation

Previous notation was k<column><row>.

* gonnerd.h: change LAYOUT_60 macro to use direct matrix

... instead of mapping through LAYOUT_tkl.

* info.json update

- use four-space indent
- update key labels to k<row><column> notation from k<column><row>
- use one key per line formatting

* split gonnerd codebase

Splits the unified gonnerd codebase into:

- gon/nerd60/ (NerD 60)
- gon/nerdtkl/ (NerD TKL)

* nerd60: cleanup rules.mk files

nerd60/rules.mk has the following changes:

- NKRO_ENABLE flipped from no to yes
- BACKLIGHT_ENABLE flipped from yes to no

Both nerd60 keymaps used the above settings, so using that as the keyboard-level default.

With this change, both the rules.mk files for the default and mauin keymaps are identical to the keyboard's rules.mk. The default keymap's rules.mk file has been deleted, while the mauin keymap's has been updated to match the AVR template, but without any settings changes or deletions.

* nerdtkl: cleanup rules.mk files

nerdtkl/rules.mk has the following changes:

- NKRO_ENABLE flipped from no to yes
- BACKLIGHT_ENABLE flipped from yes to no

The default keymap's rules.mk used the above settings, so using that as the keyboard-level default so that keymaps/default/rules.mk can be deleted.

The gam3cat keymap's rules.mk file has been updated to more closely match the AVR template and remove the firmware size impact notes, but without any settings changes or deletions.

* differentiate codebases

Remove the irrelevant code from each board's codebase, and differentiate the product names and descriptions.

Also update the USB Device Product IDs to make them unique within QMK.

* nerd60: minimize switch matrix

The NerD 60 doesn't have any switches on Column 8, so there's no need to matrix scan that column.

* add GON folder readme

* refactor default keymaps

Make the default keymaps more complete, and add a readme for each keymap.

* add ChangeLog entry
@tzarc @noroadsleft
ChibiOS upgrade to v19.1.3 (#7597)
dbb9ffb 
* First stab at getting ChibiOS upgraded.

* Handful of others now working again.

* More updates to boards.

* More conversions of boards, hopefully.

* Add fix for converter/siemens_tastatur getting PAL_USE_CALLBACKS reset during upgrade.

* Restore unmodified/unformatted chibios config files if the upgrade scripts did nothing to them.

* Attempt to fix timers.

* Timer simplification, 100k back working.

* Attempt to sort out 32-bit timer overflow arithmetic for 16-bit timers.

* Another attempt at fixing 16-bit timers.

* Disable LTO on ChibiOS builds.

* Change LTO to a message only.

* Actually use proper makefile syntax for printing messages.

* Collect ChibiOS and ChibiOS-Contrib versions during build.

* Use 64-bit timer internally to match ChibiOS.

* Simplified timer.

* Fix SPI-based WS2812 driver.

* LTO fixes, interrupt handlers were being removed by LTO.

* Update updater script to take into account all available mcuconf updaters (prep for future versions)

* Fix up ldscript search order.

* Fix up another batch of boards.

* Add breaking changes log entry.

* Add updated board/conf files

* Remove staging files.
@zvecr @noroadsleft
Update generic f072 board files in line with ChibiOS v19.1.3 (#8162)
8f03020
@tzarc @noroadsleft
Fix ChibiOS timer overflow for 16-bit SysTick devices. (#8078)
bfbe42b
@tzarc @noroadsleft
Upgrade acheron/austin to ChibiOS 19.1.3. (#8245)
3e3eba5
@noroadsleft noroadsleft marked this pull request as ready for review February 29, 2020 19:18
noroadsleft added a commit that referenced this pull request Feb 29, 2020
@noroadsleft
2020 February 29 Breaking Changes Update (#8064)
26eef35
@noroadsleft
Copy link
Member Author

Okay, these changes are merged, but GitHub's not picking it up here. There's something about my workflow GitHub doesn't like.

26eef35

cmaier pushed a commit to cmaier/qmk_firmware that referenced this pull request Mar 1, 2020
@noroadsleft @cmaier
2020 February 29 Breaking Changes Update (qmk#8064)
5d52115
rhruiz pushed a commit to rhruiz/qmk_firmware that referenced this pull request Mar 1, 2020
@noroadsleft @rhruiz
2020 February 29 Breaking Changes Update (qmk#8064)
db52d5b
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Mar 5, 2020
@noroadsleft @HokieGeek
2020 February 29 Breaking Changes Update (qmk#8064)
01213c9
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Mar 5, 2020
Merge remote-tracking branch 'upstream/master'
b05a57b 
* upstream/master:
  Breaking Changes documentation fixes
  2020 February 29 Breaking Changes Update (qmk#8064)
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@noroadsleft @c0psrul3
2020 February 29 Breaking Changes Update (qmk#8064)
956ca1e
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
@noroadsleft @sowbug
2020 February 29 Breaking Changes Update (qmk#8064)
22baf1a
@LeReverandNox LeReverandNox mentioned this pull request Apr 17, 2020
Open
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@noroadsleft @kujawakk
2020 February 29 Breaking Changes Update (qmk#8064)
44455fb
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Apr 22, 2020
@noroadsleft @drashna
2020 February 29 Breaking Changes Update (qmk#8064)
918efd3
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jun 12, 2020
@noroadsleft @fdidron
2020 February 29 Breaking Changes Update (qmk#8064)
f01c45e
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@noroadsleft @jakeisnt
2020 February 29 Breaking Changes Update (qmk#8064)
6cfd370
mechie added a commit to mechie/keyboard-configs that referenced this pull request Nov 29, 2020
@mechie
Slow down music tempo to sidestep upstream issue.
b88ce24 
Seems like PR#8064 (qmk/qmk_firmware#8064) may
have borked song playback for several keyboards, notably Plancks and
Preonics. My rev3 is affected.

By increasing the tempo to the max for its type (255 for uint8_t), the
music sounds more correct (still a bit off, but it's the simplest fix I
could identify).

I'll be tracking the relevant issues and (hopefully) revert this once
upstream has a fix.
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@noroadsleft
2020 February 29 Breaking Changes Update (qmk#8064)
575d739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@noroadsleft @tzarc @Maxr1998 @skullydazed @drashna @fauxpark @zvecr