Refactor Planck keymaps to use Layout Macros #7172

noroadsleft · 2019-10-27T01:05:26Z

Description

This PR refactors all the Planck keymaps to use layout macros instead of raw matrix. In addition, I've concatenated the file includes of the affected keymap.c files to use #include QMK_KEYBOARD_H. Additional includes are left in as needed.

I've tried to make these changes as low-impact as possible for the benefit of the users affected by these changes.

Also semi-hoping this reduces the workload on our Travis CI infrastructure.

Keymaps affected

Click for details...

Hiding this because it's huge. Not actually using mentions and PR links because I'm not convinced doing that won't actually crash GitHub.

ab (submitted by abperiasamy in PR435)
alexey (submitted by alexeyzab in PR40)
altgr (submitted by sdothum in PR2887)
andylikescandy (submitted by Andreuha in PR3399)
aviator (submitted by ramsayjp in PR2204)
basic (submitted by jackhumbert via PR2)
bone2planck (submitted by VoodaGod in PR257)
brandon (submitted by lasko in PR140)
cbbrowne (submitted by jackhumbert via PR123)
chance (submitted by take-a-CHANCE in PR1407)
circuit (submitted by mld2443 in PR637)
coloneljesus (submitted by BalzGuenat in PR1531)
corvec (submitted by corvec in PR2487)
danielhklein (submitted by danielhklein in PR2783)
dbroqua (submitted by Dbroqua in PR659)
dc (submitted by dmcollom in PR2356)
dcompact (submitted by loksonarius in PR3145)
dlaroe (submitted by dlaroe in PR2554)
dodger (submitted by ArtfulDodge in PR2609)
dr0ck (submitted by DeepThought9000 in PR2031)
dudeofawesome (submitted by dudeofawesome in PR1929)
emilyh (submitted by rooski15 in PR2221)
espynn (submitted by folkert4 in PR1041)
experimental (submitted by jackhumbert in PR314)
gabriel (submitted by gdiegel in PR39)
grahampheath (submitted by loadedsith in PR2422)
gunp (submitted by gunpinyo in PR1898)
handwired_binaryplease (submitted by binaryplease in PR1382)
hiea (submitted by sdothum in PR2887)
hieax (submitted by sdothum in PR2887)
impossible (submitted by UnderSampled in PR771)
jacob (submitted by Bilger321 in PR328)
jeebak (submitted by jeebak in PR594)
jeremy-dev (submitted by jcowgar in PR988)
jhenahan (submitted by jhenahan in PR703)
jirgn (submitted by jirgn in PR2320)
johannes (submitted by Johannes-Larsson in PR1319)
kelorean (submitted by KeLorean in PR2331)
khord (submitted by Khord in PR1162)
kloki (submitted by kloki in PR2140)
kmontag42 (submitted by KMontag42 in PR1822)
lae3 (submitted by laelath in PR1253)
lukas (submitted by spydon in PR153)
luke (submitted by LukeSilva in PR1046)
mason (submitted by McAllaster in PR2263)
matrixman (submitted by MatrixManAtYrService in PR1768)
mjt (submitted by mterhar in PR1641)
mjtnumsym (submitted by mterhar in PR1641)
mollat (submitted by mollat in PR110)
myoung34 (submitted by myoung34 in PR2035)
neo2planck (submitted by yellowmoneybank in PR2032)
nico (submitted by nicosuave in PR244)
not-quite-neo (submitted by jola5 in PR2318)
originerd (submitted by originerd in PR1350)
paget (submitted by alex-paget in PR1889)
palleiko (submitted by palleiko in PR3096)
pete (submitted by petereichinger in PR340)
phreed (submitted by phreed in PR1749)
piemod (submitted by dwrz in PR1549)
pok3r (submitted by cheesemacfly in PR1701)
premek (submitted by premek in PR638)
pvc (submitted by IBNobody in PR291)
rai-suta (submitted by rai-suta in PR1431)
rodhaene (submitted by RobertDhaene in PR2609)
sdothum (submitted by sdothum in PR2887)
sean (submitted by huntse in PR1706)
sgoodwin (submitted by sgoodwin in PR724)
smt (submitted by smt in PR1048)
steno (submitted by Talljoe in PR1522)
tak3over (submitted by unites via PR233)
tehwalris (submitted by tehwalris in PR1778)
that_canadian (submitted by That-Canadian in PR2463)
thermal_printer (submitted by jackhumbert in PR918)
unicode (submitted by jackhumbert in PR333)
yale (submitted by y4le in PR1047)
yang (submitted by yangliu in PR106)
zach (submitted by ZNielsen in PR1189)
zrichard (submitted by BigTuna94 in PR2100)
angerthosenear (submitted by jackhumbert via `cda23c754e4d16438e2b42d86b4ce9a1eadc03d7`)
austin (submitted by jackhumbert via `d61d1f5ca3a7dcccc495ac6688e0632c601c0623`)
charlie (submitted by jackhumbert via `b90ee43f57ac6ecf862f6a25cbce5ececc7a868e`)
daniel (submitted by jackhumbert via `49ba5817c43262b50e711facdb7a7b2ff7616a71`)
david (submitted by jackhumbert via `cda23c754e4d16438e2b42d86b4ce9a1eadc03d7`)
dzobert (submitted by jackhumbert via `f7bca5c41a638700022092dc0e506570c4712273`)
joe (submitted by jackhumbert via `cda23c754e4d16438e2b42d86b4ce9a1eadc03d7`)
kyle (submitted by jackhumbert via `f7bca5c41a638700022092dc0e506570c4712273`)
leo (submitted by jackhumbert via `cda23c754e4d16438e2b42d86b4ce9a1eadc03d7`)
lucas (submitted by deepshitgoeshere in PR165)
max (submitted by jackhumbert via `cda23c754e4d16438e2b42d86b4ce9a1eadc03d7`)
mitch (submitted by mitchlloyd in PR1013)
samuel (submitted by asamwow in PR4998)
tong92 (submitted by tong92 in PR736)

To-Do List

Post a changelog
Notify the affected users, maybe? (and how?)
???

Types of Changes

Enhancement/optimization
Keymap/layout/userspace (addition or update)

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

noroadsleft · 2019-11-06T11:28:24Z

`#7277` SHOULD BE MERGED INTO `future` BEFORE THIS PR

Because #7277 touches the same files as this PR, they will conflict when merged.

fauxpark's PR is smaller, so IMO his should go in first, and then I'll integrate his changes here.

* refactor ab keymap * refactor alexey keymap * refactor altgr keymap * refactor andylikescandy keymap * refactor aviator keymap * refactor basic keymap * refactor bone2planck keymap * refactor brandon keymap * refactor cbbrowne keymap * refactor chance keymap * refactor circuit keymap * refactor coloneljesus keymap * refactor corvec keymap * refactor danielhklein keymap * refactor dbroqua keymap * refactor dc keymap * refactor dcompact keymap * refactor dlaroe keymap * refactor dodger keymap * refactor dr0ck keymap * refactor dudeofawesome keymap * refactor emilyh keymap * refactor espynn keymap * refactor experimental keymap * refactor gabriel keymap * refactor grahampheath keymap * refactor gunp keymap * refactor handwired_binaryplease keymap * refactor hiea keymap * refactor hieax keymap * refactor impossible keymap * refactor jacob keymap * refactor jeebak keymap * refactor jeremy-dev keymap * refactor jhenahan keymap * refactor jirgn keymap * refactor johannes keymap * refactor kelorean keymap * refactor khord keymap * refactor kloki keymap * refactor kmontag42 keymap * refactor lae3 keymap * refactor lukas keymap * refactor luke keymap * refactor mason keymap * refactor matrixman keymap * refactor mjt keymap * refactor mjtnumsym keymap * refactor mollat keymap * refactor myoung34 keymap * refactor neo2planck keymap * refactor nico keymap * refactor not-quite-neo keymap * refactor originerd keymap * refactor paget keymap * refactor palleiko keymap * refactor pete keymap * refactor phreed keymap * refactor piemod keymap * refactor pok3r keymap * refactor premek keymap * refactor pvc keymap * refactor rai-suta keymap * refactor rodhaene keymap * refactor sdothum keymap * refactor sean keymap * refactor sgoodwin keymap * refactor smt keymap * refactor steno keymap * refactor tak3over keymap * refactor tehwalris keymap * refactor that_canadian keymap * refactor thermal_printer keymap * refactor unicode keymap * refactor yale keymap * refactor yang keymap * refactor zach keymap * refactor zrichard keymap * refactor angerthosenear keymap * refactor austin keymap * refactor charlie keymap * refactor daniel keymap * refactor david keymap * refactor dzobert keymap * refactor joe keymap * refactor kyle keymap * refactor leo keymap * refactor lucas keymap * refactor max keymap * refactor mitch keymap * refactor samuel keymap * refactor tong92 keymap * Add Changelog entry * move changelog (new breaking changes target date)

noroadsleft added optimization keymap breaking_change Changes that need to wait for a version increment future_2019q3 labels Oct 27, 2019

noroadsleft requested a review from a team October 27, 2019 01:05

fauxpark approved these changes Oct 27, 2019

View reviewed changes

drashna approved these changes Oct 28, 2019

View reviewed changes

noroadsleft mentioned this pull request Nov 6, 2019

Migrate ACTION_LAYER_TAP_KEY() to LT() #7277

Merged

13 tasks

noroadsleft force-pushed the future branch from 243bd39 to 847fb17 Compare November 23, 2019 21:06

noroadsleft force-pushed the future branch from 847fb17 to 45b6ce9 Compare January 4, 2020 20:12

noroadsleft added 19 commits January 9, 2020 17:40

refactor ab keymap

9523b1c

refactor alexey keymap

70026fb

refactor altgr keymap

95801b2

refactor andylikescandy keymap

44bd133

refactor aviator keymap

83920a3

refactor basic keymap

4701885

refactor bone2planck keymap

7ab1368

refactor brandon keymap

baa6434

refactor cbbrowne keymap

4c8a166

refactor chance keymap

ee4dec1

refactor circuit keymap

99ce579

refactor coloneljesus keymap

c7467b6

refactor corvec keymap

50f48e1

refactor danielhklein keymap

c796843

refactor dbroqua keymap

9148c34

refactor dc keymap

7c4cc60

refactor dcompact keymap

b8643e6

refactor dlaroe keymap

a9ae026

refactor dodger keymap

0408dc3

noroadsleft added 14 commits January 9, 2020 19:57

refactor charlie keymap

c038945

refactor daniel keymap

0681fdd

refactor david keymap

249c198

refactor dzobert keymap

3c0d643

refactor joe keymap

6dcd927

refactor kyle keymap

017da53

refactor leo keymap

d77496e

refactor lucas keymap

aaab493

refactor max keymap

d31d031

refactor mitch keymap

23c37fd

refactor samuel keymap

95f0931

refactor tong92 keymap

d2041d4

Add Changelog entry

e2fbf69

move changelog (new breaking changes target date)

697e986

noroadsleft force-pushed the future_planck branch from 76d2c09 to 697e986 Compare January 10, 2020 04:41

noroadsleft merged commit 0357b1c into qmk:future Jan 10, 2020

noroadsleft deleted the future_planck branch January 10, 2020 06:45

noroadsleft restored the future_planck branch January 10, 2020 06:46

noroadsleft deleted the future_planck branch June 2, 2020 03:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor Planck keymaps to use Layout Macros #7172

Refactor Planck keymaps to use Layout Macros #7172

noroadsleft commented Oct 27, 2019 •

edited

Loading

noroadsleft commented Nov 6, 2019 •

edited

Loading

Refactor Planck keymaps to use Layout Macros #7172

Refactor Planck keymaps to use Layout Macros #7172

Conversation

noroadsleft commented Oct 27, 2019 • edited Loading

Description

Keymaps affected

Hiding this because it's huge. Not actually using mentions and PR links because I'm not convinced doing that won't *actually* crash GitHub.

To-Do List

Types of Changes

Checklist

noroadsleft commented Nov 6, 2019 • edited Loading

#7277 SHOULD BE MERGED INTO future BEFORE THIS PR

noroadsleft commented Oct 27, 2019 •

edited

Loading

Hiding this because it's huge. Not actually using mentions and PR links because I'm not convinced doing that won't actually crash GitHub.

noroadsleft commented Nov 6, 2019 •

edited

Loading

`#7277` SHOULD BE MERGED INTO `future` BEFORE THIS PR