Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generic f072 board files in line with ChibiOS v19.1.3 #8162

Merged
merged 1 commit into from
Feb 15, 2020
Merged

Update generic f072 board files in line with ChibiOS v19.1.3 #8162

merged 1 commit into from
Feb 15, 2020

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 13, 2020 •
edited
Loading

Description

ChibiOS upgrade means these board files need a little update here and there. These are still the default board files, with the name and enter_bootloader_mode_if_requested patch applied.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested review from tzarc and noroadsleft February 13, 2020 20:37
@tzarc
Copy link
Member

tzarc commented Feb 13, 2020

Will check this out once future is rebased.

@zvecr zvecr changed the base branch from master to future February 14, 2020 00:06
@zvecr zvecr force-pushed the feature/f072_reboot_future branch from be1155a to b576abc Compare February 14, 2020 21:01
@zvecr zvecr marked this pull request as ready for review February 14, 2020 21:02
noroadsleft
noroadsleft approved these changes Feb 15, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__attribute__ ((weak)) ✔️

Don't see anything concerning, but I'm also the least likely to spot something wrong here.

@tzarc
Copy link
Member

tzarc commented Feb 15, 2020

LGTM

@noroadsleft noroadsleft merged commit 60789ce into qmk:future Feb 15, 2020
@noroadsleft noroadsleft added the breaking_change Changes that need to wait for a version increment label Feb 17, 2020
noroadsleft pushed a commit to noroadsleft/qmk_firmware that referenced this pull request Feb 21, 2020
@zvecr @noroadsleft
Update generic f072 board files in line with ChibiOS v19.1.3 (qmk#8162)
af87481
noroadsleft pushed a commit that referenced this pull request Feb 27, 2020
@zvecr @noroadsleft
Update generic f072 board files in line with ChibiOS v19.1.3 (#8162)
8f03020
@zvecr zvecr deleted the feature/f072_reboot_future branch April 28, 2020 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
breaking_change Changes that need to wait for a version increment core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @tzarc @noroadsleft