Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move backlight keycode handling to process_keycode/ #7008

Merged
merged 6 commits into from
Jan 10, 2020
Merged

Move backlight keycode handling to process_keycode/ #7008

merged 6 commits into from
Jan 10, 2020

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Oct 11, 2019 •
edited
Loading

Description

This seems to shave 30 54 bytes off of the default Satan keymap. I only have my Wasdat right now, but I commandeered the scroll lock LED and it works great.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team October 11, 2019 00:19
@yanfali yanfali added the breaking_change Changes that need to wait for a version increment label Oct 11, 2019
yanfali
yanfali approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@yanfali yanfali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good cleanup.

drashna
drashna approved these changes Oct 12, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, definitely a breaking change, since it significantly changes how the keycodes are handled.

@fauxpark
Copy link
Member Author

It changes the order in which they are checked slightly, but IMO it would be more the removal of ACTION_BACKLIGHT_* completely. I already got rid of all their usages in the first round of breaking changes.

@fauxpark fauxpark changed the base branch from master to future November 5, 2019 07:59
noroadsleft
noroadsleft approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@noroadsleft noroadsleft merged commit 929fe4b into qmk:future Jan 10, 2020
@fauxpark fauxpark deleted the process-backlight branch January 10, 2020 01:27
noroadsleft pushed a commit that referenced this pull request Jan 11, 2020
@fauxpark @noroadsleft
[Core] Move backlight keycode handling to process_keycode/ (#7008)
b4f0923 
* Move backlight keycode handling to process_keycode/

* Switch keycode only when pressed

* Remove default case

* Add ChangeLog entry

* New breaking changes target date
noroadsleft pushed a commit that referenced this pull request Jan 21, 2020
@fauxpark @noroadsleft
[Core] Move backlight keycode handling to process_keycode/ (#7008)
7408e3c 
* Move backlight keycode handling to process_keycode/

* Switch keycode only when pressed

* Remove default case

* Add ChangeLog entry

* New breaking changes target date
noroadsleft pushed a commit to noroadsleft/qmk_firmware that referenced this pull request Jan 24, 2020
@fauxpark @noroadsleft
[Core] Move backlight keycode handling to process_keycode/ (qmk#7008)
b8e01f7 
* Move backlight keycode handling to process_keycode/

* Switch keycode only when pressed

* Remove default case

* Add ChangeLog entry

* New breaking changes target date
noroadsleft pushed a commit to noroadsleft/qmk_firmware that referenced this pull request Feb 1, 2020
@fauxpark @noroadsleft
[Core] Move backlight keycode handling to process_keycode/ (qmk#7008)
9e9b468 
* Move backlight keycode handling to process_keycode/

* Switch keycode only when pressed

* Remove default case

* Add ChangeLog entry

* New breaking changes target date
noroadsleft pushed a commit to noroadsleft/qmk_firmware that referenced this pull request Feb 1, 2020
@fauxpark @noroadsleft
[Core] Move backlight keycode handling to process_keycode/ (qmk#7008)
03a7010 
* Move backlight keycode handling to process_keycode/

* Switch keycode only when pressed

* Remove default case

* Add ChangeLog entry

* New breaking changes target date
noroadsleft pushed a commit to noroadsleft/qmk_firmware that referenced this pull request Feb 8, 2020
@fauxpark @noroadsleft
[Core] Move backlight keycode handling to process_keycode/ (qmk#7008)
8e6b707 
* Move backlight keycode handling to process_keycode/

* Switch keycode only when pressed

* Remove default case

* Add ChangeLog entry

* New breaking changes target date
noroadsleft pushed a commit to noroadsleft/qmk_firmware that referenced this pull request Feb 14, 2020
@fauxpark @noroadsleft
[Core] Move backlight keycode handling to process_keycode/ (qmk#7008)
5fc6404 
* Move backlight keycode handling to process_keycode/

* Switch keycode only when pressed

* Remove default case

* Add ChangeLog entry

* New breaking changes target date
noroadsleft pushed a commit to noroadsleft/qmk_firmware that referenced this pull request Feb 21, 2020
@fauxpark @noroadsleft
[Core] Move backlight keycode handling to process_keycode/ (qmk#7008)
1e23fa1 
* Move backlight keycode handling to process_keycode/

* Switch keycode only when pressed

* Remove default case

* Add ChangeLog entry

* New breaking changes target date
noroadsleft pushed a commit that referenced this pull request Feb 27, 2020
@fauxpark @noroadsleft
[Core] Move backlight keycode handling to process_keycode/ (#7008)
a9dac51 
* Move backlight keycode handling to process_keycode/

* Switch keycode only when pressed

* Remove default case

* Add ChangeLog entry

* New breaking changes target date
@fauxpark fauxpark mentioned this pull request Mar 1, 2020
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

@yanfali yanfali yanfali approved these changes

Assignees
No one assigned
Labels
breaking_change Changes that need to wait for a version increment core optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fauxpark @yanfali @drashna @noroadsleft