Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add workflow for codebase formatting #7382

Merged
merged 4 commits into from
Dec 10, 2020
Merged

CI: Add workflow for codebase formatting #7382

merged 4 commits into from
Dec 10, 2020

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 16, 2019 •
edited
Loading

Description

Migrate formatting logic from travis to CLI, hock up to GitHub Actions.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr changed the title Add workflow for internal docs generation Add workflow for codebase formatting Nov 16, 2019
@zvecr zvecr force-pushed the feature/actions_code_format branch from b97fdc4 to db84206 Compare November 16, 2019 22:42
@drashna drashna requested a review from a team November 17, 2019 16:13
@drashna drashna requested a review from a team November 17, 2019 16:14
@stale

This comment has been minimized.

Sign in to view
@stale stale bot removed the awaiting changes label Jan 3, 2020
@zvecr zvecr force-pushed the feature/actions_code_format branch 2 times, most recently from 84ad0e1 to 1f227da Compare February 3, 2020 01:38
@zvecr zvecr marked this pull request as ready for review February 4, 2020 22:32
@zvecr zvecr changed the title Add workflow for codebase formatting CI: Add workflow for codebase formatting Feb 4, 2020
@zvecr zvecr added cli qmk cli command python labels Feb 4, 2020
@tzarc tzarc requested a review from a team February 5, 2020 23:04
Duckle29
Duckle29 approved these changes Feb 5, 2020
View reviewed changes
.github/workflows/format.yaml Outdated Show resolved Hide resolved
.github/workflows/format.yaml Outdated Show resolved Hide resolved
skullydazed
skullydazed reviewed Feb 15, 2020
View reviewed changes
lib/python/qmk/cli/fileformat.py Outdated Show resolved Hide resolved
.github/workflows/format.yaml Show resolved Hide resolved
@tzarc
Copy link
Member

tzarc commented Jul 25, 2020

@zvecr should we get this in? Are there any other pending changes required?

@tzarc
Copy link
Member

tzarc commented Nov 10, 2020

Got a merge conflict.

@zvecr zvecr force-pushed the feature/actions_code_format branch from 1f227da to 5d86ea8 Compare November 24, 2020 15:54
@zvecr zvecr force-pushed the feature/actions_code_format branch from 5d86ea8 to 18f37ef Compare December 6, 2020 13:34
@zvecr zvecr merged commit 6c4b653 into qmk:master Dec 10, 2020
ahaurw01 added a commit to ahaurw01/qmk_firmware that referenced this pull request Dec 11, 2020
@ahaurw01
Merge remote-tracking branch 'upstream/master'
1e98fe3 
* upstream/master: (44 commits)
  Fixed french quotes on canadian multilingual (qmk#11183)
  Nightingale Studios Hailey production fixes (qmk#11180)
  CI automated format fixes (qmk#11179)
  Add XD75am as supported in XD75 readme (qmk#11170)
  Normalise include statements in core code (qmk#11153)
  Fix warning logic when running 'qmk format -a' (qmk#11177)
  CI: Add workflow for codebase formatting (qmk#7382)
  add Via keymap for beatervan (qmk#11159)
  add VIA keymap for edc40 (qmk#11160)
  Use progmem.h for claw44 glcdfont (qmk#11164)
  [Keyboard] Valor FRL TKL update - EEPROM change (qmk#11163)
  Fixup config template to match <> instead of "" for includes. (qmk#11166)
  Fix titan60 and h660 error_log complaints (qmk#11124)
  [Keymap] Fix rules.mk for nullbits nibble oled keymap (qmk#11142)
  [Keyboard] Geekboards Macropad V2 keyboard (qmk#11045)
  Fixed taleguers75 info.json (qmk#11121)
  Add missing hardware availability for Plank EZ (qmk#11069)
  [Keyboard] Big Dill Extended by MechWild (qmk#11047)
  add via layout for aek2 usb pcb (qmk#11125)
  [Keyboard] Add nt980 (qmk#11092)
  ...
nicsuzor added a commit to nicsuzor/qmk_firmware that referenced this pull request Dec 16, 2020
@nicsuzor
Merge remote-tracking branch 'upstream/master'
38d6b39 
* upstream/master: (183 commits)
  Normalise include statements in keyboard code (qmk#11185)
  CLI-ify rgblight_breathing_table_calc.c (qmk#11174)
  gh60/satan: fix indicator LED define (qmk#11216)
  [Keymap] Helix default keymap oled update (qmk#11152)
  [Keyboard] rart/rart45 (qmk#11096)
  Selectively enable command and console for yanfali userspace (qmk#11212)
  Another attempt to fix formatting workflow (qmk#11187)
  Add i2c 24LC64 eeprom (qmk#11200)
  Fix incorrect search order for `rgblight_breathe_table.h` that `rgblight.c` includes. (qmk#11192)
  Fixed french quotes on canadian multilingual (qmk#11183)
  Nightingale Studios Hailey production fixes (qmk#11180)
  CI automated format fixes (qmk#11179)
  Add XD75am as supported in XD75 readme (qmk#11170)
  Normalise include statements in core code (qmk#11153)
  Fix warning logic when running 'qmk format -a' (qmk#11177)
  CI: Add workflow for codebase formatting (qmk#7382)
  add Via keymap for beatervan (qmk#11159)
  add VIA keymap for edc40 (qmk#11160)
  Use progmem.h for claw44 glcdfont (qmk#11164)
  [Keyboard] Valor FRL TKL update - EEPROM change (qmk#11163)
  ...
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@zvecr @xgnxs
CI: Add workflow for codebase formatting (qmk#7382)
a012095 
* Add workflow for codebase formatting

* stash

* review comments

* Swap to a more complete push action
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
CI: Add workflow for codebase formatting (qmk#7382)
fbd592c 
* Add workflow for codebase formatting

* stash

* review comments

* Swap to a more complete push action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skullydazed skullydazed skullydazed left review comments

@fauxpark fauxpark fauxpark left review comments

@Erovia Erovia Erovia left review comments

@Duckle29 Duckle29 Duckle29 approved these changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
awaiting review CI cli qmk cli command core enhancement python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@zvecr @tzarc @drashna @Duckle29 @Erovia @fauxpark @skullydazed @noroadsleft