Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect oled test keymap #11142

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Fix incorrect oled test keymap #11142

merged 1 commit into from
Dec 9, 2020

Conversation

jaygreco
Copy link
Contributor

@jaygreco jaygreco commented Dec 7, 2020

Description

The previously submitted OLED test keymap had a mistake in rules.mk. It is corrected here.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the keymap label Dec 7, 2020
@fauxpark fauxpark requested a review from a team December 7, 2020 05:19
@drashna drashna merged commit 56933b9 into qmk:master Dec 9, 2020
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Dec 10, 2020
@jaygreco @tacahiroy
[Keymap] Fix rules.mk for nullbits nibble oled keymap (qmk#11142)
487fdd2
ahaurw01 added a commit to ahaurw01/qmk_firmware that referenced this pull request Dec 11, 2020
@ahaurw01
Merge remote-tracking branch 'upstream/master'
1e98fe3 
* upstream/master: (44 commits)
  Fixed french quotes on canadian multilingual (qmk#11183)
  Nightingale Studios Hailey production fixes (qmk#11180)
  CI automated format fixes (qmk#11179)
  Add XD75am as supported in XD75 readme (qmk#11170)
  Normalise include statements in core code (qmk#11153)
  Fix warning logic when running 'qmk format -a' (qmk#11177)
  CI: Add workflow for codebase formatting (qmk#7382)
  add Via keymap for beatervan (qmk#11159)
  add VIA keymap for edc40 (qmk#11160)
  Use progmem.h for claw44 glcdfont (qmk#11164)
  [Keyboard] Valor FRL TKL update - EEPROM change (qmk#11163)
  Fixup config template to match <> instead of "" for includes. (qmk#11166)
  Fix titan60 and h660 error_log complaints (qmk#11124)
  [Keymap] Fix rules.mk for nullbits nibble oled keymap (qmk#11142)
  [Keyboard] Geekboards Macropad V2 keyboard (qmk#11045)
  Fixed taleguers75 info.json (qmk#11121)
  Add missing hardware availability for Plank EZ (qmk#11069)
  [Keyboard] Big Dill Extended by MechWild (qmk#11047)
  add via layout for aek2 usb pcb (qmk#11125)
  [Keyboard] Add nt980 (qmk#11092)
  ...
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@jaygreco @xgnxs
[Keymap] Fix rules.mk for nullbits nibble oled keymap (qmk#11142)
b3007c8
@jaygreco jaygreco deleted the fix_oled_keymap branch May 13, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaygreco @drashna @fauxpark