Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valor FRL TKL update - EEPROM change #11163

Merged
merged 3 commits into from
Dec 9, 2020
Merged

Valor FRL TKL update - EEPROM change #11163

merged 3 commits into from
Dec 9, 2020

Conversation

Xelus22
Copy link
Contributor

@Xelus22 Xelus22 commented Dec 9, 2020

Description

Changes the EEPROM define to reflect the proper chip used.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Fix EEPROM chip

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a pretty different change. Any boards with the old controller?

Also, may be worth adding this to the list of predefined chips, too.

@drashna drashna requested a review from a team December 9, 2020 02:32
@Xelus22
Copy link
Contributor Author

Xelus22 commented Dec 9, 2020 •
edited
Loading

There are no boards with the previous EEPROM chip as I changed to 64kB and I think this is still plenty of space.

Yep I can add in an eeprom setting/define for this one.

@drashna
Copy link
Member

drashna commented Dec 9, 2020

Okay, just wanted to make sure nobody would get bitten by the change.

And yeah, 64k is super large!

@drashna drashna merged commit cd67074 into qmk:master Dec 9, 2020
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Dec 10, 2020
@Xelus22 @tacahiroy
[Keyboard] Valor FRL TKL update - EEPROM change (qmk#11163)
c61acfe 
* valor fix

* change eeprom

* fix up eeprom
ahaurw01 added a commit to ahaurw01/qmk_firmware that referenced this pull request Dec 11, 2020
@ahaurw01
Merge remote-tracking branch 'upstream/master'
1e98fe3 
* upstream/master: (44 commits)
  Fixed french quotes on canadian multilingual (qmk#11183)
  Nightingale Studios Hailey production fixes (qmk#11180)
  CI automated format fixes (qmk#11179)
  Add XD75am as supported in XD75 readme (qmk#11170)
  Normalise include statements in core code (qmk#11153)
  Fix warning logic when running 'qmk format -a' (qmk#11177)
  CI: Add workflow for codebase formatting (qmk#7382)
  add Via keymap for beatervan (qmk#11159)
  add VIA keymap for edc40 (qmk#11160)
  Use progmem.h for claw44 glcdfont (qmk#11164)
  [Keyboard] Valor FRL TKL update - EEPROM change (qmk#11163)
  Fixup config template to match <> instead of "" for includes. (qmk#11166)
  Fix titan60 and h660 error_log complaints (qmk#11124)
  [Keymap] Fix rules.mk for nullbits nibble oled keymap (qmk#11142)
  [Keyboard] Geekboards Macropad V2 keyboard (qmk#11045)
  Fixed taleguers75 info.json (qmk#11121)
  Add missing hardware availability for Plank EZ (qmk#11069)
  [Keyboard] Big Dill Extended by MechWild (qmk#11047)
  add via layout for aek2 usb pcb (qmk#11125)
  [Keyboard] Add nt980 (qmk#11092)
  ...
nicsuzor added a commit to nicsuzor/qmk_firmware that referenced this pull request Dec 16, 2020
@nicsuzor
Merge remote-tracking branch 'upstream/master'
38d6b39 
* upstream/master: (183 commits)
  Normalise include statements in keyboard code (qmk#11185)
  CLI-ify rgblight_breathing_table_calc.c (qmk#11174)
  gh60/satan: fix indicator LED define (qmk#11216)
  [Keymap] Helix default keymap oled update (qmk#11152)
  [Keyboard] rart/rart45 (qmk#11096)
  Selectively enable command and console for yanfali userspace (qmk#11212)
  Another attempt to fix formatting workflow (qmk#11187)
  Add i2c 24LC64 eeprom (qmk#11200)
  Fix incorrect search order for `rgblight_breathe_table.h` that `rgblight.c` includes. (qmk#11192)
  Fixed french quotes on canadian multilingual (qmk#11183)
  Nightingale Studios Hailey production fixes (qmk#11180)
  CI automated format fixes (qmk#11179)
  Add XD75am as supported in XD75 readme (qmk#11170)
  Normalise include statements in core code (qmk#11153)
  Fix warning logic when running 'qmk format -a' (qmk#11177)
  CI: Add workflow for codebase formatting (qmk#7382)
  add Via keymap for beatervan (qmk#11159)
  add VIA keymap for edc40 (qmk#11160)
  Use progmem.h for claw44 glcdfont (qmk#11164)
  [Keyboard] Valor FRL TKL update - EEPROM change (qmk#11163)
  ...
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
@Xelus22 @xgnxs
[Keyboard] Valor FRL TKL update - EEPROM change (qmk#11163)
51fb2b9 
* valor fix

* change eeprom

* fix up eeprom
@Xelus22 Xelus22 deleted the valor_frl_tkl_proper branch June 2, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xelus22 @drashna @fauxpark