Fix incorrect search order for rgblight_breathe_table.h that rgblight.c includes.
#11192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ght.c` includes. When `rgblight.c` includes `rgblight_breathe_table.h`, the search order should be as follows. * `keyboards/KEYBOARD/keymaps/USER/rgblight_breathe_table.h` * `users/USER/rgblight_breathe_table.h` * `quantum/rgblight_breathe_table.h` However, the current implementation was wrong, so I fixed it.
|
I changed this in #11153. It seems wrong. |
fauxpark
approved these changes
Dec 12, 2020
nicsuzor
added a commit
to nicsuzor/qmk_firmware
that referenced
this pull request
Dec 16, 2020
* upstream/master: (183 commits) Normalise include statements in keyboard code (qmk#11185) CLI-ify rgblight_breathing_table_calc.c (qmk#11174) gh60/satan: fix indicator LED define (qmk#11216) [Keymap] Helix default keymap oled update (qmk#11152) [Keyboard] rart/rart45 (qmk#11096) Selectively enable command and console for yanfali userspace (qmk#11212) Another attempt to fix formatting workflow (qmk#11187) Add i2c 24LC64 eeprom (qmk#11200) Fix incorrect search order for `rgblight_breathe_table.h` that `rgblight.c` includes. (qmk#11192) Fixed french quotes on canadian multilingual (qmk#11183) Nightingale Studios Hailey production fixes (qmk#11180) CI automated format fixes (qmk#11179) Add XD75am as supported in XD75 readme (qmk#11170) Normalise include statements in core code (qmk#11153) Fix warning logic when running 'qmk format -a' (qmk#11177) CI: Add workflow for codebase formatting (qmk#7382) add Via keymap for beatervan (qmk#11159) add VIA keymap for edc40 (qmk#11160) Use progmem.h for claw44 glcdfont (qmk#11164) [Keyboard] Valor FRL TKL update - EEPROM change (qmk#11163) ...
xgnxs
pushed a commit
to xgnxs/qmk_firmware
that referenced
this pull request
Jan 9, 2021
…ght.c` includes. (qmk#11192) When `rgblight.c` includes `rgblight_breathe_table.h`, the search order should be as follows. * `keyboards/KEYBOARD/keymaps/USER/rgblight_breathe_table.h` * `users/USER/rgblight_breathe_table.h` * `quantum/rgblight_breathe_table.h` However, the current implementation was wrong, so I fixed it.
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jan 13, 2021
…ght.c` includes. (qmk#11192) When `rgblight.c` includes `rgblight_breathe_table.h`, the search order should be as follows. * `keyboards/KEYBOARD/keymaps/USER/rgblight_breathe_table.h` * `users/USER/rgblight_breathe_table.h` * `quantum/rgblight_breathe_table.h` However, the current implementation was wrong, so I fixed it.
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
…ght.c` includes. (qmk#11192) When `rgblight.c` includes `rgblight_breathe_table.h`, the search order should be as follows. * `keyboards/KEYBOARD/keymaps/USER/rgblight_breathe_table.h` * `users/USER/rgblight_breathe_table.h` * `quantum/rgblight_breathe_table.h` However, the current implementation was wrong, so I fixed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
rgblight.cincludesrgblight_breathe_table.h, the search order should be as follows.keyboards/KEYBOARD/keymaps/USER/rgblight_breathe_table.husers/USER/rgblight_breathe_table.hquantum/rgblight_breathe_table.hHowever, the current implementation was wrong, so I fixed it.
Scope of impact of this PR change
Currently, there are only two custom rgblight_breathe_table.h
users/drashna/rgblight_breathe_table.husers/curry/rgblight_breathe_table.hAt first glance,
currydoes not seem to be alive at present. The following command will result in an error regardless of this PR.Therefore, only
users/drashnais affected by this PR. (Tag @drashna)This PR will be merged into
master, since the affected area is clear.Types of Changes
Checklist